Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Shell limitation #306

Merged
merged 3 commits into from
Mar 2, 2022
Merged

doc: Shell limitation #306

merged 3 commits into from
Mar 2, 2022

Conversation

allevo
Copy link
Contributor

@allevo allevo commented Feb 24, 2022

As discussed in #305

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

I still think this is fixable, I just don't know where the problem is and I have no way to debug it. I think a session with a debugger could fix it.

@allevo
Copy link
Contributor Author

allevo commented Feb 24, 2022

I really doesn't have enough experience for deep debug this issue. But I'm open to share my screen 😄 or send me some links

Readme.md Outdated Show resolved Hide resolved
Co-authored-by: James Sumners <james@sumners.email>
@mcollina
Copy link
Member

How about adding a sentence saying that a PR from a Windows expert would be useful?

@allevo
Copy link
Contributor Author

allevo commented Mar 2, 2022

Updated as request

@mcollina mcollina merged commit 25b0e51 into pinojs:master Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants