-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-org code (retry) #453
Merged
Merged
Re-org code (retry) #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollina
approved these changes
Aug 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rubberstamp lgtm
renovate bot
referenced
this pull request
in fwouts/previewjs
Oct 4, 2023
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [pino-pretty](https://togithub.com/pinojs/pino-pretty) | [`^10.2.0` -> `^10.2.3`](https://renovatebot.com/diffs/npm/pino-pretty/10.2.0/10.2.3) | [![age](https://developer.mend.io/api/mc/badges/age/npm/pino-pretty/10.2.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/pino-pretty/10.2.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/pino-pretty/10.2.0/10.2.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/pino-pretty/10.2.0/10.2.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pinojs/pino-pretty (pino-pretty)</summary> ### [`v10.2.3`](https://togithub.com/pinojs/pino-pretty/releases/tag/v10.2.3) [Compare Source](https://togithub.com/pinojs/pino-pretty/compare/v10.2.2...v10.2.3) #### What's Changed - Manually require and export all util scripts by [@​marvinruder](https://togithub.com/marvinruder) in [https://github.com/pinojs/pino-pretty/pull/467](https://togithub.com/pinojs/pino-pretty/pull/467) #### New Contributors - [@​marvinruder](https://togithub.com/marvinruder) made their first contribution in [https://github.com/pinojs/pino-pretty/pull/467](https://togithub.com/pinojs/pino-pretty/pull/467) **Full Changelog**: pinojs/pino-pretty@v10.2.2...v10.2.3 ### [`v10.2.2`](https://togithub.com/pinojs/pino-pretty/releases/tag/v10.2.2) [Compare Source](https://togithub.com/pinojs/pino-pretty/compare/602be25a622812f8fbc2be318d4338a718c32902...v10.2.2) #### What's Changed - Add basic benchmark suite by [@​jsumners](https://togithub.com/jsumners) in [https://github.com/pinojs/pino-pretty/pull/451](https://togithub.com/pinojs/pino-pretty/pull/451) - Re-org code (retry) by [@​jsumners](https://togithub.com/jsumners) in [https://github.com/pinojs/pino-pretty/pull/453](https://togithub.com/pinojs/pino-pretty/pull/453) - Bump tsd from 0.28.1 to 0.29.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/pinojs/pino-pretty/pull/454](https://togithub.com/pinojs/pino-pretty/pull/454) - Bump actions/checkout from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/pinojs/pino-pretty/pull/461](https://togithub.com/pinojs/pino-pretty/pull/461) - Disable FinalizationRegistry if NODE_V8\_COVERAGE is set by [@​mcollina](https://togithub.com/mcollina) in [https://github.com/pinojs/pino-pretty/pull/464](https://togithub.com/pinojs/pino-pretty/pull/464) **Full Changelog**: pinojs/pino-pretty@v10.2.0...v10.2.2 ### [`v10.2.1`](https://togithub.com/pinojs/pino-pretty/compare/v10.2.0...602be25a622812f8fbc2be318d4338a718c32902) [Compare Source](https://togithub.com/pinojs/pino-pretty/compare/v10.2.0...602be25a622812f8fbc2be318d4338a718c32902) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/fwouts/previewjs). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4wLjMiLCJ1cGRhdGVkSW5WZXIiOiIzNy4wLjMiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
bodinsamuel
referenced
this pull request
in specfy/specfy
Nov 3, 2023
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [pino-pretty](https://togithub.com/pinojs/pino-pretty) | [`10.2.0` -> `10.2.3`](https://renovatebot.com/diffs/npm/pino-pretty/10.2.0/10.2.3) | [![age](https://developer.mend.io/api/mc/badges/age/npm/pino-pretty/10.2.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/pino-pretty/10.2.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/pino-pretty/10.2.0/10.2.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/pino-pretty/10.2.0/10.2.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pinojs/pino-pretty (pino-pretty)</summary> ### [`v10.2.3`](https://togithub.com/pinojs/pino-pretty/releases/tag/v10.2.3) [Compare Source](https://togithub.com/pinojs/pino-pretty/compare/v10.2.2...v10.2.3) #### What's Changed - Manually require and export all util scripts by [@​marvinruder](https://togithub.com/marvinruder) in [https://github.com/pinojs/pino-pretty/pull/467](https://togithub.com/pinojs/pino-pretty/pull/467) #### New Contributors - [@​marvinruder](https://togithub.com/marvinruder) made their first contribution in [https://github.com/pinojs/pino-pretty/pull/467](https://togithub.com/pinojs/pino-pretty/pull/467) **Full Changelog**: pinojs/pino-pretty@v10.2.2...v10.2.3 ### [`v10.2.2`](https://togithub.com/pinojs/pino-pretty/releases/tag/v10.2.2) [Compare Source](https://togithub.com/pinojs/pino-pretty/compare/602be25a622812f8fbc2be318d4338a718c32902...v10.2.2) #### What's Changed - Add basic benchmark suite by [@​jsumners](https://togithub.com/jsumners) in [https://github.com/pinojs/pino-pretty/pull/451](https://togithub.com/pinojs/pino-pretty/pull/451) - Re-org code (retry) by [@​jsumners](https://togithub.com/jsumners) in [https://github.com/pinojs/pino-pretty/pull/453](https://togithub.com/pinojs/pino-pretty/pull/453) - Bump tsd from 0.28.1 to 0.29.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/pinojs/pino-pretty/pull/454](https://togithub.com/pinojs/pino-pretty/pull/454) - Bump actions/checkout from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/pinojs/pino-pretty/pull/461](https://togithub.com/pinojs/pino-pretty/pull/461) - Disable FinalizationRegistry if NODE_V8\_COVERAGE is set by [@​mcollina](https://togithub.com/mcollina) in [https://github.com/pinojs/pino-pretty/pull/464](https://togithub.com/pinojs/pino-pretty/pull/464) **Full Changelog**: pinojs/pino-pretty@v10.2.0...v10.2.2 ### [`v10.2.1`](https://togithub.com/pinojs/pino-pretty/compare/v10.2.0...602be25a622812f8fbc2be318d4338a718c32902) [Compare Source](https://togithub.com/pinojs/pino-pretty/compare/v10.2.0...602be25a622812f8fbc2be318d4338a718c32902) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 4pm every weekday" in timezone Europe/Paris, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/specfy/specfy). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMS41IiwidXBkYXRlZEluVmVyIjoiMzcuMzEuNSIsInRhcmdldEJyYW5jaCI6ImNob3JlL3Jlbm92YXRlQmFzZUJyYW5jaCJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a replacement for #449 that GH closed and won't let me reopen.
The impetus for this PR was me starting to work on a suggestion PR for #445. When I got into the code, I decided that we have long ago outgrown the structure of the codebase as I created it when splitting this module out of the core Pino module. Basically, it has grown in a difficult to navigate mess with everything crammed into a few large files.
I have more that I intend to do, but I think this PR has become large enough as it is. So I'm halting my work until we make a decision on this (🤞 that means it's merged).
This PR is not yet complete as of commit 065fc99. I just want to put it up to show the following:
As of that commit, the "utils" file has been split out into a directory,
lib/utils/
. This directory has one file per utility function and a corresponding test file for each utility function file. It also updates thetap
configuration to include a coverage map. The result is that we are not actually covering at 100% as we assumed:Coverage Report
Okay, so that's not quite true. The difference is that some of the coverage comes through the factory function tests. With the restructure we have 1:1 test to code and we can see the gaps. it is my opinion that we should be able to recognize that file Y covers code X. Prior to this PR, one has to dig through a lot of code to find where something might be covering the code in question. As an example, in order to properly cover a case in
handle-custom-levels-opts
andhandle-custom-levels-names-opts
I had to read back through the git blame and learn what code was added to cover an odd branch.After rebasing this on #451, I get numbers like this for the changes in this PR:
So, roughly no change in performance by splitting the functions out into their own files/scopes.