Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TS types #30

Merged
merged 11 commits into from
May 26, 2021
Merged

Add TS types #30

merged 11 commits into from
May 26, 2021

Conversation

kibertoad
Copy link
Contributor

@kibertoad
Copy link
Contributor Author

@mcollina Could you also check this one out?

.travis.yml Outdated
@@ -16,6 +22,7 @@ node_js:
script:
- npm run lint-ci
- npm run test-ci
- ${TSSCRIPT:-echo "Skip TS tests"}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed because older Node versions that we still support are not compatible.

@kibertoad
Copy link
Contributor Author

@mcollina This is ready for review.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

package.json Outdated
@@ -3,11 +3,22 @@
"version": "2.5.0",
"description": "A collection of standard object serializers for Pino",
"main": "index.js",
"type": "commonjs",
"types": "index.d.ts",
"files": [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not want to maintain this property.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed.

@kibertoad
Copy link
Contributor Author

@jsumners Is it OK now?

@jsumners
Copy link
Member

Yes.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit da13977 into pinojs:master May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants