-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TS types #30
Add TS types #30
Conversation
@mcollina Could you also check this one out? |
.travis.yml
Outdated
@@ -16,6 +22,7 @@ node_js: | |||
script: | |||
- npm run lint-ci | |||
- npm run test-ci | |||
- ${TSSCRIPT:-echo "Skip TS tests"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is needed because older Node versions that we still support are not compatible.
… into feat/types � Conflicts: � .travis.yml � package.json
@mcollina This is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
package.json
Outdated
@@ -3,11 +3,22 @@ | |||
"version": "2.5.0", | |||
"description": "A collection of standard object serializers for Pino", | |||
"main": "index.js", | |||
"type": "commonjs", | |||
"types": "index.d.ts", | |||
"files": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not want to maintain this property.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed.
@jsumners Is it OK now? |
Yes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
refs pinojs/pino#913
refs pinojs/pino#910