Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Make sure transports are required. Fixes #43. #45

Merged
merged 3 commits into from
Jun 16, 2022
Merged

fix: Make sure transports are required. Fixes #43. #45

merged 3 commits into from
Jun 16, 2022

Conversation

ShogunPanda
Copy link
Collaborator

@ShogunPanda ShogunPanda commented Jun 15, 2022 •
edited
Loading

Fixes #43.

@simoneb
Copy link
Collaborator

simoneb commented Jun 15, 2022

Shall we have a test? Sound like a fairly simple use case to test

@ShogunPanda
Copy link
Collaborator Author

@simoneb Done! ^^

@simoneb
Copy link
Collaborator

simoneb commented Jun 15, 2022

@ShogunPanda booom 💥

mcollina
mcollina approved these changes Jun 15, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ShogunPanda
Copy link
Collaborator Author

Can I merge this?

@ShogunPanda ShogunPanda merged commit 168348a into pinojs:main Jun 16, 2022
@ShogunPanda ShogunPanda deleted the ensure-transport-requires branch June 16, 2022 12:53
@github-actions github-actions bot mentioned this pull request Jun 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@simoneb simoneb simoneb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Transport js file is not generated unless I include a dummy import to the transport module
3 participants
@ShogunPanda @simoneb @mcollina