chore: remove test directory & non-existent files from dist

[ydcjeff]

Users don't need test in the final package.

[jsumners]

I know we had a long discussion in #136 and #137 about this topic, but I think we should readdress it. My statements in fastify/skeleton#42 (comment) are being proved here. We routinely ignore (package.json).files and it clearly gets out-of-date. I'd rather we:

1. have a simple .gitignore
2. remove (package.json).files
3. do not add a .npmignore file

@mcollina @davidmarkclements what are your thoughts?

[ydcjeff]

So are we going to have test in .gitignore (we shouldn't ignore test, right?) or will new .gitignore be created when releasing?

[jsumners]

So are we going to have test in .gitignore

No. We want it included.

[ydcjeff]

If we are going to have only .gitignore, test directory will still be included in the final distribution.

[jsumners]

If we are going to have only .gitignore, test directory will still be included in the final distribution.

Correct. We are fine with that. When we are working on projects and need to dig into why a dependency isn't working as expected, or just need to understand the dependency better, we will read the included test files.

[ydcjeff]

Yes, I agree with that, but I usually read the source on GitHub, so test files are unnecessary at least for me.

[mcollina]

Those files are there because we want them there.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.