fix: typescript types #1783
Merged
fix: typescript types #1783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, I think I understand the error, due to my changes the TypeScript compiler is actually catching the runtime error that the code is intentionally performing, LOL. |
|
There is a "breaking" change in this PR (depending on how exactly you want to define breaking) such that you can no longer use the first generic type parameter as a means to validate the object that you are passing. Users should be directed to use the ( |
|
Oh, looks like the tests are failing because the version of TypeScript is too old to have the |
|
@Zamiell yes, please! |
|
Actually, on second thought, the version of TypeScript is really recent. Can someone click the button to re-run CI for me (since I'm a first time contributor)? |
|
From the CI logs: But according to the package.json file at the root of the repository, the version of TypeScript is 5.1.3, which should have the satisfies operator, which was introduced in TypeScript version 4.9.0. Thus, I conclude that the CI is running on an old version of the dependencies, so something in this repo is broken with respect to caching and/or Can a maintainer take a look at this please? |
|
@mcollina Can we work to get this merged? It's been sitting for a while. |
|
I don't have time to investigate at the moment Happy to land with a green CI. |
|
@mcollina Can we get another maintainer to investigate? I'm fairly certain that the errors in CI are not related to my PR. |
|
CI is passing on master, please rebase |
I'm aware of that, I am talking about the CI errors inside of this pull request. Can we get another maintainer to investigate? |
|
You need to rebase this PR. |
|
@jsumners I rebased this PR onto master just now. Let me know if anything additional is required. |
|
CI is failing |
|
@mcollina Sorry, I think we are looping. Yes, CI is failing for the same reason that I posted in my reply on October 4th here: #1783 (comment) This reply explains why the errors are not part of my PR and why I think that a maintainer needs to investigate: #1783 (comment) To recap, in response to asking for a maintainer to look at the logs, it was requested that I rebase the PR on main, which I have now done, but CI still gives the same error, so we are back to square 1, and I would ask again that a maintainer please take a look at these logs, as they do not seem related to my PR! |
|
What I can tell you is that |
|
@jsumners It fails on this branch because I am using TypeScript's |
|
I can take a look on Monday |
|
There isn't a cache on my local system. The only way TS is even on my system is through |
renovate bot
referenced
this pull request
in fwouts/previewjs
Dec 26, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [pino](https://getpino.io) ([source](https://togithub.com/pinojs/pino)) | [`^8.16.2` -> `^8.17.2`](https://renovatebot.com/diffs/npm/pino/8.16.2/8.17.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pinojs/pino (pino)</summary> ### [`v8.17.2`](https://togithub.com/pinojs/pino/releases/tag/v8.17.2) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.17.1...v8.17.2) #### What's Changed - build(deps): bump process-warning from 2.3.2 to 3.0.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/pinojs/pino/pull/1869](https://togithub.com/pinojs/pino/pull/1869) - fix: type of child logger with custom levels by [@​UndefinedBehaviour](https://togithub.com/UndefinedBehaviour) in [https://github.com/pinojs/pino/pull/1871](https://togithub.com/pinojs/pino/pull/1871) **Full Changelog**: pinojs/pino@v8.17.1...v8.17.2 ### [`v8.17.1`](https://togithub.com/pinojs/pino/releases/tag/v8.17.1) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.17.0...v8.17.1) #### What's Changed - Support unknown, reverts 1783, add tests by [@​mcollina](https://togithub.com/mcollina) in [https://github.com/pinojs/pino/pull/1866](https://togithub.com/pinojs/pino/pull/1866) - Add Type Example for custom logger by [@​mcollina](https://togithub.com/mcollina) in [https://github.com/pinojs/pino/pull/1867](https://togithub.com/pinojs/pino/pull/1867) **Full Changelog**: pinojs/pino@v8.17.0...v8.17.1 ### [`v8.17.0`](https://togithub.com/pinojs/pino/releases/tag/v8.17.0) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.16.2...v8.17.0) #### What's Changed - build(deps): bump actions/github-script from 6 to 7 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/pinojs/pino/pull/1857](https://togithub.com/pinojs/pino/pull/1857) - Make license detectable by GitHub by [@​10xLaCroixDrinker](https://togithub.com/10xLaCroixDrinker) in [https://github.com/pinojs/pino/pull/1859](https://togithub.com/pinojs/pino/pull/1859) - docs: Clarify how to log both to a custom transport and to stdout by [@​kibertoad](https://togithub.com/kibertoad) in [https://github.com/pinojs/pino/pull/1860](https://togithub.com/pinojs/pino/pull/1860) - Fix/types by [@​UndefinedBehaviour](https://togithub.com/UndefinedBehaviour) in [https://github.com/pinojs/pino/pull/1858](https://togithub.com/pinojs/pino/pull/1858) - Bumped tsd to v0.29.0 by [@​mcollina](https://togithub.com/mcollina) in [https://github.com/pinojs/pino/pull/1863](https://togithub.com/pinojs/pino/pull/1863) - fix: typescript types by [@​Zamiell](https://togithub.com/Zamiell) in [https://github.com/pinojs/pino/pull/1783](https://togithub.com/pinojs/pino/pull/1783) - build(deps): bump pnpm/action-setup from 2.2.4 to 2.4.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/pinojs/pino/pull/1766](https://togithub.com/pinojs/pino/pull/1766) #### New Contributors - [@​10xLaCroixDrinker](https://togithub.com/10xLaCroixDrinker) made their first contribution in [https://github.com/pinojs/pino/pull/1859](https://togithub.com/pinojs/pino/pull/1859) - [@​Zamiell](https://togithub.com/Zamiell) made their first contribution in [https://github.com/pinojs/pino/pull/1783](https://togithub.com/pinojs/pino/pull/1783) **Full Changelog**: pinojs/pino@v8.16.2...v8.17.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/fwouts/previewjs). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44Ny4yIiwidXBkYXRlZEluVmVyIjoiMzcuMTAzLjEiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
renovate bot
referenced
this pull request
in redwoodjs/redwood
Mar 19, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [pino](https://getpino.io) ([source](https://togithub.com/pinojs/pino)) | [`8.16.2` -> `8.19.0`](https://renovatebot.com/diffs/npm/pino/8.16.2/8.19.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pinojs/pino (pino)</summary> ### [`v8.19.0`](https://togithub.com/pinojs/pino/releases/tag/v8.19.0) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.18.0...v8.19.0) #### What's Changed - api.md: Fix link declaration by [@​homersimpsons](https://togithub.com/homersimpsons) in [https://github.com/pinojs/pino/pull/1900](https://togithub.com/pinojs/pino/pull/1900) - Update transports.md by [@​huijiewei](https://togithub.com/huijiewei) in [https://github.com/pinojs/pino/pull/1897](https://togithub.com/pinojs/pino/pull/1897) - Add a basic `formatters` option to the browser pino by [@​KatelynKim](https://togithub.com/KatelynKim) in [https://github.com/pinojs/pino/pull/1898](https://togithub.com/pinojs/pino/pull/1898) - `setLevel` should respect level comparison option by [@​obrus-corcentric](https://togithub.com/obrus-corcentric) in [https://github.com/pinojs/pino/pull/1901](https://togithub.com/pinojs/pino/pull/1901) - Add formatters log option by [@​KatelynKim](https://togithub.com/KatelynKim) in [https://github.com/pinojs/pino/pull/1905](https://togithub.com/pinojs/pino/pull/1905) #### New Contributors - [@​homersimpsons](https://togithub.com/homersimpsons) made their first contribution in [https://github.com/pinojs/pino/pull/1900](https://togithub.com/pinojs/pino/pull/1900) - [@​huijiewei](https://togithub.com/huijiewei) made their first contribution in [https://github.com/pinojs/pino/pull/1897](https://togithub.com/pinojs/pino/pull/1897) - [@​KatelynKim](https://togithub.com/KatelynKim) made their first contribution in [https://github.com/pinojs/pino/pull/1898](https://togithub.com/pinojs/pino/pull/1898) **Full Changelog**: pinojs/pino@v8.18.0...v8.19.0 ### [`v8.18.0`](https://togithub.com/pinojs/pino/releases/tag/v8.18.0) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.17.2...v8.18.0) #### What's Changed - build(deps): bump actions/upload-artifact from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/pinojs/pino/pull/1873](https://togithub.com/pinojs/pino/pull/1873) - chore(license): Update licensing year by [@​codershiba](https://togithub.com/codershiba) in [https://github.com/pinojs/pino/pull/1882](https://togithub.com/pinojs/pino/pull/1882) - fix: destination docs and types by [@​codershiba](https://togithub.com/codershiba) in [https://github.com/pinojs/pino/pull/1881](https://togithub.com/pinojs/pino/pull/1881) - Correct type of `pino`'s `stream` parameter by [@​quisido](https://togithub.com/quisido) in [https://github.com/pinojs/pino/pull/1874](https://togithub.com/pinojs/pino/pull/1874) - Add ability to override custom levels comparison by [@​obrus-corcentric](https://togithub.com/obrus-corcentric) in [https://github.com/pinojs/pino/pull/1883](https://togithub.com/pinojs/pino/pull/1883) - build(deps-dev): bump tsd from 0.29.0 to 0.30.4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/pinojs/pino/pull/1888](https://togithub.com/pinojs/pino/pull/1888) #### New Contributors - [@​codershiba](https://togithub.com/codershiba) made their first contribution in [https://github.com/pinojs/pino/pull/1882](https://togithub.com/pinojs/pino/pull/1882) - [@​quisido](https://togithub.com/quisido) made their first contribution in [https://github.com/pinojs/pino/pull/1874](https://togithub.com/pinojs/pino/pull/1874) - [@​obrus-corcentric](https://togithub.com/obrus-corcentric) made their first contribution in [https://github.com/pinojs/pino/pull/1883](https://togithub.com/pinojs/pino/pull/1883) **Full Changelog**: pinojs/pino@v8.17.2...v8.18.0 ### [`v8.17.2`](https://togithub.com/pinojs/pino/releases/tag/v8.17.2) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.17.1...v8.17.2) #### What's Changed - build(deps): bump process-warning from 2.3.2 to 3.0.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/pinojs/pino/pull/1869](https://togithub.com/pinojs/pino/pull/1869) - fix: type of child logger with custom levels by [@​UndefinedBehaviour](https://togithub.com/UndefinedBehaviour) in [https://github.com/pinojs/pino/pull/1871](https://togithub.com/pinojs/pino/pull/1871) **Full Changelog**: pinojs/pino@v8.17.1...v8.17.2 ### [`v8.17.1`](https://togithub.com/pinojs/pino/releases/tag/v8.17.1) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.17.0...v8.17.1) #### What's Changed - Support unknown, reverts 1783, add tests by [@​mcollina](https://togithub.com/mcollina) in [https://github.com/pinojs/pino/pull/1866](https://togithub.com/pinojs/pino/pull/1866) - Add Type Example for custom logger by [@​mcollina](https://togithub.com/mcollina) in [https://github.com/pinojs/pino/pull/1867](https://togithub.com/pinojs/pino/pull/1867) **Full Changelog**: pinojs/pino@v8.17.0...v8.17.1 ### [`v8.17.0`](https://togithub.com/pinojs/pino/releases/tag/v8.17.0) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.16.2...v8.17.0) #### What's Changed - build(deps): bump actions/github-script from 6 to 7 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/pinojs/pino/pull/1857](https://togithub.com/pinojs/pino/pull/1857) - Make license detectable by GitHub by [@​10xLaCroixDrinker](https://togithub.com/10xLaCroixDrinker) in [https://github.com/pinojs/pino/pull/1859](https://togithub.com/pinojs/pino/pull/1859) - docs: Clarify how to log both to a custom transport and to stdout by [@​kibertoad](https://togithub.com/kibertoad) in [https://github.com/pinojs/pino/pull/1860](https://togithub.com/pinojs/pino/pull/1860) - Fix/types by [@​UndefinedBehaviour](https://togithub.com/UndefinedBehaviour) in [https://github.com/pinojs/pino/pull/1858](https://togithub.com/pinojs/pino/pull/1858) - Bumped tsd to v0.29.0 by [@​mcollina](https://togithub.com/mcollina) in [https://github.com/pinojs/pino/pull/1863](https://togithub.com/pinojs/pino/pull/1863) - fix: typescript types by [@​Zamiell](https://togithub.com/Zamiell) in [https://github.com/pinojs/pino/pull/1783](https://togithub.com/pinojs/pino/pull/1783) - build(deps): bump pnpm/action-setup from 2.2.4 to 2.4.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/pinojs/pino/pull/1766](https://togithub.com/pinojs/pino/pull/1766) #### New Contributors - [@​10xLaCroixDrinker](https://togithub.com/10xLaCroixDrinker) made their first contribution in [https://github.com/pinojs/pino/pull/1859](https://togithub.com/pinojs/pino/pull/1859) - [@​Zamiell](https://togithub.com/Zamiell) made their first contribution in [https://github.com/pinojs/pino/pull/1783](https://togithub.com/pinojs/pino/pull/1783) **Full Changelog**: pinojs/pino@v8.16.2...v8.17.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/redwoodjs/redwood). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNDUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjI0NS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: David Price <thedavid@thedavidprice.com>
thedavidprice
referenced
this pull request
in redwoodjs/redwood
Mar 27, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [pino](https://getpino.io) ([source](https://togithub.com/pinojs/pino)) | [`8.16.2` -> `8.19.0`](https://renovatebot.com/diffs/npm/pino/8.16.2/8.19.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pinojs/pino (pino)</summary> ### [`v8.19.0`](https://togithub.com/pinojs/pino/releases/tag/v8.19.0) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.18.0...v8.19.0) #### What's Changed - api.md: Fix link declaration by [@​homersimpsons](https://togithub.com/homersimpsons) in [https://github.com/pinojs/pino/pull/1900](https://togithub.com/pinojs/pino/pull/1900) - Update transports.md by [@​huijiewei](https://togithub.com/huijiewei) in [https://github.com/pinojs/pino/pull/1897](https://togithub.com/pinojs/pino/pull/1897) - Add a basic `formatters` option to the browser pino by [@​KatelynKim](https://togithub.com/KatelynKim) in [https://github.com/pinojs/pino/pull/1898](https://togithub.com/pinojs/pino/pull/1898) - `setLevel` should respect level comparison option by [@​obrus-corcentric](https://togithub.com/obrus-corcentric) in [https://github.com/pinojs/pino/pull/1901](https://togithub.com/pinojs/pino/pull/1901) - Add formatters log option by [@​KatelynKim](https://togithub.com/KatelynKim) in [https://github.com/pinojs/pino/pull/1905](https://togithub.com/pinojs/pino/pull/1905) #### New Contributors - [@​homersimpsons](https://togithub.com/homersimpsons) made their first contribution in [https://github.com/pinojs/pino/pull/1900](https://togithub.com/pinojs/pino/pull/1900) - [@​huijiewei](https://togithub.com/huijiewei) made their first contribution in [https://github.com/pinojs/pino/pull/1897](https://togithub.com/pinojs/pino/pull/1897) - [@​KatelynKim](https://togithub.com/KatelynKim) made their first contribution in [https://github.com/pinojs/pino/pull/1898](https://togithub.com/pinojs/pino/pull/1898) **Full Changelog**: pinojs/pino@v8.18.0...v8.19.0 ### [`v8.18.0`](https://togithub.com/pinojs/pino/releases/tag/v8.18.0) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.17.2...v8.18.0) #### What's Changed - build(deps): bump actions/upload-artifact from 3 to 4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/pinojs/pino/pull/1873](https://togithub.com/pinojs/pino/pull/1873) - chore(license): Update licensing year by [@​codershiba](https://togithub.com/codershiba) in [https://github.com/pinojs/pino/pull/1882](https://togithub.com/pinojs/pino/pull/1882) - fix: destination docs and types by [@​codershiba](https://togithub.com/codershiba) in [https://github.com/pinojs/pino/pull/1881](https://togithub.com/pinojs/pino/pull/1881) - Correct type of `pino`'s `stream` parameter by [@​quisido](https://togithub.com/quisido) in [https://github.com/pinojs/pino/pull/1874](https://togithub.com/pinojs/pino/pull/1874) - Add ability to override custom levels comparison by [@​obrus-corcentric](https://togithub.com/obrus-corcentric) in [https://github.com/pinojs/pino/pull/1883](https://togithub.com/pinojs/pino/pull/1883) - build(deps-dev): bump tsd from 0.29.0 to 0.30.4 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/pinojs/pino/pull/1888](https://togithub.com/pinojs/pino/pull/1888) #### New Contributors - [@​codershiba](https://togithub.com/codershiba) made their first contribution in [https://github.com/pinojs/pino/pull/1882](https://togithub.com/pinojs/pino/pull/1882) - [@​quisido](https://togithub.com/quisido) made their first contribution in [https://github.com/pinojs/pino/pull/1874](https://togithub.com/pinojs/pino/pull/1874) - [@​obrus-corcentric](https://togithub.com/obrus-corcentric) made their first contribution in [https://github.com/pinojs/pino/pull/1883](https://togithub.com/pinojs/pino/pull/1883) **Full Changelog**: pinojs/pino@v8.17.2...v8.18.0 ### [`v8.17.2`](https://togithub.com/pinojs/pino/releases/tag/v8.17.2) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.17.1...v8.17.2) #### What's Changed - build(deps): bump process-warning from 2.3.2 to 3.0.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/pinojs/pino/pull/1869](https://togithub.com/pinojs/pino/pull/1869) - fix: type of child logger with custom levels by [@​UndefinedBehaviour](https://togithub.com/UndefinedBehaviour) in [https://github.com/pinojs/pino/pull/1871](https://togithub.com/pinojs/pino/pull/1871) **Full Changelog**: pinojs/pino@v8.17.1...v8.17.2 ### [`v8.17.1`](https://togithub.com/pinojs/pino/releases/tag/v8.17.1) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.17.0...v8.17.1) #### What's Changed - Support unknown, reverts 1783, add tests by [@​mcollina](https://togithub.com/mcollina) in [https://github.com/pinojs/pino/pull/1866](https://togithub.com/pinojs/pino/pull/1866) - Add Type Example for custom logger by [@​mcollina](https://togithub.com/mcollina) in [https://github.com/pinojs/pino/pull/1867](https://togithub.com/pinojs/pino/pull/1867) **Full Changelog**: pinojs/pino@v8.17.0...v8.17.1 ### [`v8.17.0`](https://togithub.com/pinojs/pino/releases/tag/v8.17.0) [Compare Source](https://togithub.com/pinojs/pino/compare/v8.16.2...v8.17.0) #### What's Changed - build(deps): bump actions/github-script from 6 to 7 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/pinojs/pino/pull/1857](https://togithub.com/pinojs/pino/pull/1857) - Make license detectable by GitHub by [@​10xLaCroixDrinker](https://togithub.com/10xLaCroixDrinker) in [https://github.com/pinojs/pino/pull/1859](https://togithub.com/pinojs/pino/pull/1859) - docs: Clarify how to log both to a custom transport and to stdout by [@​kibertoad](https://togithub.com/kibertoad) in [https://github.com/pinojs/pino/pull/1860](https://togithub.com/pinojs/pino/pull/1860) - Fix/types by [@​UndefinedBehaviour](https://togithub.com/UndefinedBehaviour) in [https://github.com/pinojs/pino/pull/1858](https://togithub.com/pinojs/pino/pull/1858) - Bumped tsd to v0.29.0 by [@​mcollina](https://togithub.com/mcollina) in [https://github.com/pinojs/pino/pull/1863](https://togithub.com/pinojs/pino/pull/1863) - fix: typescript types by [@​Zamiell](https://togithub.com/Zamiell) in [https://github.com/pinojs/pino/pull/1783](https://togithub.com/pinojs/pino/pull/1783) - build(deps): bump pnpm/action-setup from 2.2.4 to 2.4.0 by [@​dependabot](https://togithub.com/dependabot) in [https://github.com/pinojs/pino/pull/1766](https://togithub.com/pinojs/pino/pull/1766) #### New Contributors - [@​10xLaCroixDrinker](https://togithub.com/10xLaCroixDrinker) made their first contribution in [https://github.com/pinojs/pino/pull/1859](https://togithub.com/pinojs/pino/pull/1859) - [@​Zamiell](https://togithub.com/Zamiell) made their first contribution in [https://github.com/pinojs/pino/pull/1783](https://togithub.com/pinojs/pino/pull/1783) **Full Changelog**: pinojs/pino@v8.16.2...v8.17.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/redwoodjs/redwood). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNDUuMCIsInVwZGF0ZWRJblZlciI6IjM3LjI0NS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: David Price <thedavid@thedavidprice.com>
This was referenced May 23, 2024
This was referenced Jul 17, 2024
This was referenced Sep 6, 2024
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1782
The PR causes an error in one of the existing tests:It's line 312 in "pino.test-d.ts". I don't understand the error or what it is supposed to be testing. Can anyone shed some light on this?EDIT:
try/catchblocks or loggingunknown.