-
Notifications
You must be signed in to change notification settings - Fork 889
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add @openobserve/openobserve-pino transports #2078
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We generally look for listed modules to include tests that provide a baseline level of quality assurance. Is this module tested?
docs/transports.md
Outdated
``` | ||
import pino from 'pino'; | ||
import OpenobserveTransport from '@openobserve/pino-openobserve'; | ||
|
||
const logger = pino({ | ||
level: 'info', | ||
transport: { | ||
target: OpenobserveTransport, | ||
options: { | ||
url: 'https://your-openobserve-server.com', | ||
organization: 'your-organization', | ||
streamName: 'your-stream', | ||
auth: { | ||
username: 'your-username', | ||
password: 'your-password', | ||
}, | ||
}, | ||
}, | ||
}); | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other examples in this document are CJS. Please update yours to be consistent with the others.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This example is updated with the CJS
Co-authored-by: James Sumners <321201+jsumners@users.noreply.github.com>
Co-authored-by: James Sumners <321201+jsumners@users.noreply.github.com>
@jsumners Yes this module was published on npm for more than 9 months. The tests were also recently added. So yes it does provide a baseline level of quality assurance. Feel free to review here: https://github.com/openobserve/pino-openobserve |
Hello,
We have written @openobserve/openobserve-pino v7+ transport for sending logs to OpenObserve
Feel free to review this and let us know if you have any questions.
Kirtan