Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dict key failed in requests #713

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Conversation

eeliu
Copy link
Collaborator

@eeliu eeliu commented Jan 2, 2025

Describe your changes

why we need this pr?

requests.request(**parameters) exists in many plugins, we will resovled in later version.

Issue ticket number and link

if it has issues, add them

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics?
  • Will this be part of a product update? If yes, please write one phrase about this update.

> add testcase for **parameters
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.57%. Comparing base (5187cc0) to head (c60d7c3).
Report is 66 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #713      +/-   ##
==========================================
- Coverage   80.79%   80.57%   -0.23%     
==========================================
  Files          22       22              
  Lines        1536     1539       +3     
  Branches      165      166       +1     
==========================================
- Hits         1241     1240       -1     
- Misses        162      165       +3     
- Partials      133      134       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eeliu eeliu merged commit 0a33d1d into pinpoint-apm:dev Jan 2, 2025
60 of 61 checks passed
@eeliu eeliu deleted the fix-dict-para branch January 2, 2025 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant