Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client Side gRPC Stream deadline retry refactoring #285

Open
3 of 5 tasks
feelform opened this issue Mar 4, 2025 · 0 comments · May be fixed by #286
Open
3 of 5 tasks

Client Side gRPC Stream deadline retry refactoring #285

feelform opened this issue Mar 4, 2025 · 0 comments · May be fixed by #286
Milestone

Comments

@feelform
Copy link
Collaborator

feelform commented Mar 4, 2025

  • The stream deadline configuration is loaded from pinpoint-config-default.json
  • Any value (null, undefined) should not terminate the agent because it needs to load JSON data and perform arithmetic.
  • clientSideStream should be called end method.
const writableStream = this.makeWritableStream(this.options, (error, response) => {
                writableStream.end()

        dataSender.spanStream.writableStream.on('close', () => {
            t.false(dataSender.spanStream.writableStream.writable, `If the stream is errored, the stream should be closed and not writable`)
        })
        dataSender.spanStream.writableStream.on('unpipe', () => {
            t.false(dataSender.spanStream.writableStream.writable, `If the stream is errored, the stream should be unpipe and not writable`)
        })
  • check Functional Test in grpc-data-sender-client-side-stream._test.js and refactoring Functional Test to GrpcReadableStream
  • ServiceClient Method call exception error
       } catch (error) {
            logError('try catch error in pipeWritableStream', error)
            this.lazyPipeWritableStream(retryCount + 1)
        }
feelform added a commit to feelform/pinpoint-node-agent that referenced this issue Mar 4, 2025
* The stream deadline configuration is loaded from pinpoint-config-default.json
* Any value (null, undefined) should not terminate the agent because it needs to load JSON data and perform arithmetic.
@feelform feelform added this to the 1.0.0 milestone Mar 4, 2025
@feelform feelform linked a pull request Mar 4, 2025 that will close this issue
2 tasks
feelform added a commit to feelform/pinpoint-node-agent that referenced this issue Mar 6, 2025
    * The stream deadline configuration is loaded from pinpoint-config-default.json
    * Any value (null, undefined) should not terminate the agent because it needs to load JSON data and perform arithmetic
feelform added a commit to feelform/pinpoint-node-agent that referenced this issue Mar 6, 2025
        * The stream deadline configuration is loaded from pinpoint-config-default.json
        * Any value (null, undefined) should not terminate the agent because it needs to load JSON data and perform arithmetic
feelform added a commit to feelform/pinpoint-node-agent that referenced this issue Mar 6, 2025
            * The stream deadline configuration is loaded from pinpoint-config-default.json
            * Any value (null, undefined) should not terminate the agent because it needs to load JSON data and perform arithmetic
feelform added a commit to feelform/pinpoint-node-agent that referenced this issue Mar 6, 2025
                * The stream deadline configuration is loaded from pinpoint-config-default.json
                * Any value (null, undefined) should not terminate the agent because it needs to load JSON data and perform arithmetic
feelform added a commit to feelform/pinpoint-node-agent that referenced this issue Mar 6, 2025
   * The stream deadline configuration is loaded from pinpoint-config-default.json
   * Any value (null, undefined) should not terminate the agent because it needs to load JSON data and perform arithmetic
feelform added a commit to feelform/pinpoint-node-agent that referenced this issue Mar 6, 2025
   * The stream deadline configuration is loaded from pinpoint-config-default.json
   * Any value (null, undefined) should not terminate the agent because it needs to load JSON data and perform arithmetic
feelform added a commit to feelform/pinpoint-node-agent that referenced this issue Mar 6, 2025
   * The stream deadline configuration is loaded from pinpoint-config-default.json
   * Any value (null, undefined) should not terminate the agent because it needs to load JSON data and perform arithmetic
feelform added a commit to feelform/pinpoint-node-agent that referenced this issue Mar 6, 2025
   * The stream deadline configuration is loaded from pinpoint-config-default.json
   * Any value (null, undefined) should not terminate the agent because it needs to load JSON data and perform arithmetic
* readable Stream highWaterMark = 100
feelform added a commit to feelform/pinpoint-node-agent that referenced this issue Mar 7, 2025
   * The stream deadline configuration is loaded from pinpoint-config-default.json
   * Any value (null, undefined) should not terminate the agent because it needs to load JSON data and perform arithmetic
   * readable Stream highWaterMark = 100
feelform added a commit to feelform/pinpoint-node-agent that referenced this issue Mar 7, 2025
   * The stream deadline configuration is loaded from pinpoint-config-default.json
   * Any value (null, undefined) should not terminate the agent because it needs to load JSON data and perform arithmetic
   * readable Stream highWaterMark = 100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant