Support Agent types and Adaptor pattern(Logger and configuration) #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
feelform
commented
Nov 3, 2022
•
feelform
commented
- Logger adaptor pattern Logger adaptor pattern #118
- index.d.ts index.d.ts #117
- NPM test failure NPM test failure #122
typescript tools support for .d.ts
* https://nodejs.org/api/modules.html#enabling
* fix license convention by https://docs.npmjs.com/cli/v8/configuring-npm/package-json#license
Logger Adaptor pattern
* The Logger must implements pinpoint.json config loading status and a log level.
* support integration test
* if adaptor doesn't have adaptor outer method, Agent outs logs to console
feelform
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.