Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#8934] Refactor AgentInfoFilter #9012

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

intr3p1d
Copy link
Contributor

@intr3p1d intr3p1d commented Jul 5, 2022

No description provided.

@intr3p1d intr3p1d self-assigned this Jul 5, 2022
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov
Copy link

codecov bot commented Jul 5, 2022

Codecov Report

Merging #9012 (4d60e48) into master (e4404f2) will increase coverage by 0.02%.
The diff coverage is 33.33%.

@@             Coverage Diff              @@
##             master    #9012      +/-   ##
============================================
+ Coverage     39.75%   39.78%   +0.02%     
- Complexity    11796    11816      +20     
============================================
  Files          3347     3347              
  Lines         90824    90830       +6     
  Branches      10053    10055       +2     
============================================
+ Hits          36110    36136      +26     
+ Misses        51622    51599      -23     
- Partials       3092     3095       +3     
Impacted Files Coverage Δ
.../authorization/controller/AgentInfoController.java 0.00% <ø> (ø)
...com/navercorp/pinpoint/web/vo/AgentInfoFilter.java 37.50% <33.33%> (-12.50%) ⬇️
...r/context/storage/AsyncQueueingUriStatStorage.java 69.11% <0.00%> (-16.18%) ⬇️
...om/navercorp/pinpoint/rpc/codec/PacketDecoder.java 51.66% <0.00%> (-1.67%) ⬇️
...ercorp/pinpoint/rpc/server/HealthCheckManager.java 58.97% <0.00%> (-1.29%) ⬇️
...orp/pinpoint/web/controller/CommandController.java 0.00% <0.00%> (ø)
...orp/pinpoint/web/controller/WebhookController.java 0.00% <0.00%> (ø)
...pinpoint/web/controller/ApplicationController.java 0.00% <0.00%> (ø)
...oint/web/controller/AgentStatisticsController.java 0.00% <0.00%> (ø)
...oint/web/controller/WebhookSendInfoController.java 0.00% <0.00%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4404f2...4d60e48. Read the comment docs.

@intr3p1d intr3p1d linked an issue Jul 5, 2022 that may be closed by this pull request
@intr3p1d intr3p1d requested a review from emeroad July 6, 2022 01:42
@intr3p1d intr3p1d changed the title [#8934] Refactor AgentInfoController [#8934] Refactor AgentInfoFilter Jul 6, 2022
@intr3p1d intr3p1d merged commit 7dae67b into pinpoint-apm:master Jul 6, 2022
@emeroad emeroad added this to the 2.5.0 milestone Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change existing agent list lookup policy
3 participants