Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#noissue] Polishing UrlTraceSampler #9647

Merged
merged 1 commit into from
Jan 19, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
import java.util.Objects;

public class UrlTraceSampler implements TraceSampler {
private final List<UrlPathMatcher> urlPathMatcherList;
private final UrlPathMatcher[] urlPathMatcherList;
private final TraceSampler defaultTraceSampler;

public UrlTraceSampler(Map<String, TraceSampler> urlMap, TraceSampler defaultTraceSampler) {
Expand All @@ -44,7 +44,7 @@ public UrlTraceSampler(Map<String, TraceSampler> urlMap, TraceSampler defaultTra
}
list.add(new UrlPathMatcher(urlPath, traceSampler));
}
this.urlPathMatcherList = list;
this.urlPathMatcherList = list.toArray(new UrlPathMatcher[0]);
}

@Override
Expand Down Expand Up @@ -84,9 +84,9 @@ TraceSampler getSampler(String urlPath) {
return this.defaultTraceSampler;
}

private class UrlPathMatcher implements PathMatcher {
private PathMatcher pathMatcher;
private TraceSampler traceSampler;
private static class UrlPathMatcher implements PathMatcher {
private final PathMatcher pathMatcher;
private final TraceSampler traceSampler;

public UrlPathMatcher(String urlPath, TraceSampler traceSampler) {
if (AntPathMatcher.isAntStylePattern(urlPath)) {
Expand Down