Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don/packet io - Update to cover library #2

Open
wants to merge 199 commits into
base: master
Choose a base branch
from

Conversation

donNewtonAlpha
Copy link

No description provided.

mohan-selvaraj and others added 30 commits August 16, 2019 11:27
…oadcast, unknown-unicast and unknown-multicast storm-control feature in SONiC
NPU to be replaced by ASIC/Multi-ASIC for consistency throughout the document [AI: Kartik/Arista]
=> document updated to use ASIC instead of NPU

Section 1.2: Config & Management Requirements

Rephrase second bullet to reflect port configuration is static i.e physical wiring only
=> Wording clarified as requqested

Add context in the document for dynamic port changes [AI: Kartik/Arista]
=> Section outlining dynamic system port support added in "Future Work" section

Section 2.3:  State Sharing

Update image separate Syncd,  swss, DB container per fabric chip [AI: Kartik/Arista]
=> diagram updated to show multiple syncd, one per fabric chip

Section 2.4:  Chip Management

Update section 2.4.2 to clarify switch ID numbering  scheme in the system with reference from SAI specs.  [AI: Kartik/Arista]
=> Section updated to reflect the correct numbering scheme with reference to the VOQ SAI spec.

Section 2.5:  Port Management

Section 2.5.2 update system port table schema [AI: Kartik/Arista]
=> Updated to reflect proper instance naming as below

Section 2.5.3 Update inband port to be explicitly provisioned [AI: Kartik/Arista]
=> wording around inband port is clarified.

Require more clarity what is meant by instance - if LC has two ASICs then what will instance scope mean - swss/CPU instance? Is there is 1:1 mapping between instance to ASIC?  [AI: Kartik/Arista]
=> Added new instance naming section describing naming scheme for both the FSI and an ASIC
Ifname must be unique per FSI. If we decide to create kernel devices for system ports, ifname may have to be globally unique.
AI (Kartik/Arista): Amend wording in the document
=> amended wording in the document

Any existing swss test can be run in the virtual chassis mode - except for LAG tests which aren’t compatible .
AI (Kartik/Arista) - Clarify the conditions under which existing tests can be run unchanged.
=> clarified

How would dual supervisor scenario work? What considerations do we have for two SSIs? (Danny/Microsoft)
AI (Kartik/Arista) - add a summary in Future work section.
=> added a new dual supervisor section in Future work and summarized some high level approaches
- Clarifications on DB structure and naming
- Cleaning up redundant sections that are expected to be covered in other docs
- Clarification of terminology
- Renamed Chassis DB to Global DB
- Revised the Global DB configuration structure
- Added a failure handling section
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Includes updates to address Microsoft's comments
doc/pins/Packet_io.md Outdated Show resolved Hide resolved



## Scope

This document covers the high level design aspects of Packet I/O in SONiC for P4Runtime application.
This document covers the high level design aspects of Packet I/O in SONiC for both the P4Runtime application and any subsequent application that would benifit from packet exchange using Generic Netlink Sockets.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

benifit->benefit

doc/pins/Packet_io.md Outdated Show resolved Hide resolved
doc/pins/Packet_io.md Outdated Show resolved Hide resolved
doc/pins/Packet_io.md Outdated Show resolved Hide resolved
doc/pins/Packet_io.md Outdated Show resolved Hide resolved
ai-cu and others added 20 commits April 4, 2022 12:25
Co-authored-by: Daniele Moro <daniele.moro92@gmail.com>
Co-authored-by: Daniele Moro <daniele.moro92@gmail.com>
Updated the files for double braces error as suggested by [PR#942](docker/docs#942)
Co-authored-by: Brian O'Connor <bocon@opennetworking.org>
Co-authored-by: Daniele Moro <daniele.moro92@gmail.com>
Co-authored-by: Daniele Moro <daniele.moro92@gmail.com>
Co-authored-by: Daniele Moro <daniele.moro92@gmail.com>
Co-authored-by: Brian O'Connor <bocon@opennetworking.org>
Co-authored-by: Daniele Moro <daniele.moro92@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.