Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize PINMemoryCache remove objects when receive memory warning notification #251

Conversation

kinarobin
Copy link
Contributor

If you want remove all objects, there is pointless to remove expired objects

@ghost
Copy link

ghost commented Jun 24, 2019

🚫 CI failed with log

Copy link
Collaborator

@garrettmoon garrettmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good optimization! Thanks for the PR!

@ghost
Copy link

ghost commented Jun 24, 2019

🚫 CI failed with log

@ghost
Copy link

ghost commented Jun 24, 2019

🚫 CI failed with log

@ghost
Copy link

ghost commented Jun 25, 2019

🚫 CI failed with log

@kinarobin
Copy link
Contributor Author

kinarobin commented Jun 25, 2019

@pinterest-ios Could you change build system to Legacy Build System for CI? Thanks.

https://stackoverflow.com/questions/50718018/xcode-10-error-multiple-commands-produce

@ghost
Copy link

ghost commented Jun 25, 2019

🚫 CI failed with log

@ernestmama ernestmama merged commit 79f0d30 into pinterest:master Nov 21, 2019
@kinarobin kinarobin deleted the optimize_remove_objects_when_receive_memory_warning_notification branch November 22, 2019 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants