Pulls out speed monitoring and adds support for using cell vs. wifi if speed unavailable. #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onnection (wifi vs cellular)
garrettmoon
changed the title
garrettmoon
changed the title
nguyenhuy
approved these changes
Sep 1, 2017
|
|
||
| [strongSelf lock]; | ||
| BOOL shouldUpgradeLowQualityImages = [strongSelf shouldUpgradeLowQualityImages]; | ||
| [strongSelf unlock]; |
There was a problem hiding this comment.
This may well be a micro-optimization, but to avoid grabbing the lock multiple times, how about taking this chance to get high and low quality thresholds and pass them to -appropriateImageIdxForURLsGivenHistoricalNetworkConditions? Then that method can be static because it no longer needs access to self.
Generated by 🚫 Danger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.