Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CurrentBaseline is deprecated in 0.46.* #1517

Closed
nulls opened this issue Jun 22, 2022 · 1 comment · Fixed by #1569
Closed

CurrentBaseline is deprecated in 0.46.* #1517

nulls opened this issue Jun 22, 2022 · 1 comment · Fixed by #1569
Milestone

Comments

@nulls
Copy link
Contributor

nulls commented Jun 22, 2022

Hi,

We (diktat) are migrating to ktlint 0.46.* and found that CurrentBaseline was marked as deprecated in scope of #1117.

We have own maven and gradle plugins where we call KtLint.format() and KtLint.lint() instead of run com.pinterest.ktlint.internal.KtlintCommandLine and we need to have access to baseline for it: we check that found LintError doesn't present in baseline.

Is it possible to keep CurrentBaseline as public API or provide a new to get API to generate and read baseline?

Thanks

@nulls nulls changed the title CurrentBaseline is deprecated CurrentBaseline is deprecated in 0.46.* Jun 22, 2022
@paul-dingemans
Copy link
Collaborator

Thanks for reporting this. The reason for this deprecation was indeed to find out whether it has any value to our API Consumers. The name of the class however is not clear from the viewpoint of ktlint as we have no distinction between current and old baseline. So, I will rename the class CurrentBaseline to something like Baseline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants