Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor 'CurrentBaseline' to 'Baseline' in public 'api' package #1569

Conversation

paul-dingemans
Copy link
Collaborator

@paul-dingemans paul-dingemans commented Aug 3, 2022

Description

KtLint does not distinct between old or new baseline. Hence, the term CurrentBaseline
is meaningless. The class was located in the internal package but was exposed in
the public API and is used by Diktat. Now the class is moved to the public API
package and documented more properly.

Closes #1517

Checklist

  • PR description added
  • tests are added
  • KtLint has been applied on source code itself and violations are fixed
  • documentation is updated
  • CHANGELOG.md is updated

In case of adding a new rule:

KtLint does not distinct between old or new baseline. Hence, the term CurrentBaseline
is meaningless. The class was located in the `internal` package but was exposed in
the public API and is used by Diktat. Now the class is moved to the public API
package and documented more properly.
@paul-dingemans paul-dingemans added this to the 0.47.0 milestone Aug 3, 2022
@paul-dingemans paul-dingemans merged commit 6ed2589 into pinterest:master Aug 7, 2022
@paul-dingemans paul-dingemans deleted the 1517-refactor-current-baseline branch August 7, 2022 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CurrentBaseline is deprecated in 0.46.*
1 participant