-
Notifications
You must be signed in to change notification settings - Fork 509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build task experimental rules #1307
Add build task experimental rules #1307
Commits on Dec 12, 2021
-
Add separate verification build step to include experimental rules
Ktlint should apply the dogfooding principal and only provide experimental rules that at least on the ktlint code base itself gives satisfiable results. Initially all experimental rules that cause violations have been disabled, so that a separate commit can be created to enable each specific rule.
Paul Dingemans committedDec 12, 2021 Configuration menu - View commit details
-
Copy full SHA for 4c969c6 - Browse repository at this point
Copy the full SHA 4c969c6View commit details -
Enable rule experimental:spacing-between-declarations-with-comments
For BaselineTests it was necessary to rename the files which are used for testing to have a non standard kotlin file extension. This prevents the files from being changed when running the ktlint formatting on the ktlint code base itself. Note that the baseline protection mechanism did work in this case and as of that has been removed from the command.
Paul Dingemans committedDec 12, 2021 Configuration menu - View commit details
-
Copy full SHA for 9bdfb9a - Browse repository at this point
Copy the full SHA 9bdfb9aView commit details -
Enable rule experimental:no-empty-first-line-in-method-block
Paul Dingemans committedDec 12, 2021 Configuration menu - View commit details
-
Copy full SHA for 47e9799 - Browse repository at this point
Copy the full SHA 47e9799View commit details -
Enable rule experimental:annotation
Paul Dingemans committedDec 12, 2021 Configuration menu - View commit details
-
Copy full SHA for 5e2b8d5 - Browse repository at this point
Copy the full SHA 5e2b8d5View commit details -
Resolve some violations of rule experimental:argument-list-wrapping
It is not yet possible to enable the rule as some violations are actually false positives. This will be solved by pinterest#1284
Paul Dingemans committedDec 12, 2021 Configuration menu - View commit details
-
Copy full SHA for 378a0a3 - Browse repository at this point
Copy the full SHA 378a0a3View commit details -
Enable rule experimental:spacing-between-declarations-with-annotations
Paul Dingemans committedDec 12, 2021 Configuration menu - View commit details
-
Copy full SHA for ae40195 - Browse repository at this point
Copy the full SHA ae40195View commit details -
Enable rule experimental:trailing-comma
For now, it has been chosen to disallow trailing comma's instead of forcing them to be added. Reasons for this are two folded. The number of changes is considerably smaller. More importantly is that the benefit, with respect to avoiding future merge conflicts, seems not that big when scanning the code change which would result from forcing the trailing comma to be added.
Paul Dingemans committedDec 12, 2021 Configuration menu - View commit details
-
Copy full SHA for 76eb011 - Browse repository at this point
Copy the full SHA 76eb011View commit details -
Paul Dingemans committed
Dec 12, 2021 Configuration menu - View commit details
-
Copy full SHA for 6944d59 - Browse repository at this point
Copy the full SHA 6944d59View commit details -
Remove autocorrect mode from build step ktlint_experimental
Paul Dingemans committedDec 12, 2021 Configuration menu - View commit details
-
Copy full SHA for 8642e87 - Browse repository at this point
Copy the full SHA 8642e87View commit details
Commits on Dec 13, 2021
-
Run the experimental rules by default
There is no need for a separate build task to run the experimental rules. The experimental rules can be executed by default in the "ktlint" task. Also, the baseline has been fixed so there is no longer a need to use extension "_kt" for the baseline test files. Closes pinterest#1222
Paul Dingemans committedDec 13, 2021 Configuration menu - View commit details
-
Copy full SHA for fd17608 - Browse repository at this point
Copy the full SHA fd17608View commit details -
Merge branch 'master' into add-build-task-experimental-rules
Paul Dingemans committedDec 13, 2021 Configuration menu - View commit details
-
Copy full SHA for 0b97269 - Browse repository at this point
Copy the full SHA 0b97269View commit details
Commits on Dec 14, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 916e3c9 - Browse repository at this point
Copy the full SHA 916e3c9View commit details -
Configuration menu - View commit details
-
Copy full SHA for dffe890 - Browse repository at this point
Copy the full SHA dffe890View commit details -
Configuration menu - View commit details
-
Copy full SHA for 48603bf - Browse repository at this point
Copy the full SHA 48603bfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 44d88e0 - Browse repository at this point
Copy the full SHA 44d88e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for b46ed06 - Browse repository at this point
Copy the full SHA b46ed06View commit details -
Configuration menu - View commit details
-
Copy full SHA for b8d48b4 - Browse repository at this point
Copy the full SHA b8d48b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 05147af - Browse repository at this point
Copy the full SHA 05147afView commit details
Commits on Dec 18, 2021
-
Merge remote-tracking branch 'upstream/master' into add-build-task-ex…
…perimental-rules # Conflicts: # CHANGELOG.md # build.gradle
Paul Dingemans committedDec 18, 2021 Configuration menu - View commit details
-
Copy full SHA for 74cc001 - Browse repository at this point
Copy the full SHA 74cc001View commit details -
Exclude all test resources from the ktlint module from the linting task
Those source files all contain linting errors which have to be reported by unit tests. Therefore they should not be reported during a normal build because those should not be fixed as that would result in the tests to fail.
Paul Dingemans committedDec 18, 2021 Configuration menu - View commit details
-
Copy full SHA for 9956e61 - Browse repository at this point
Copy the full SHA 9956e61View commit details -
Revert renaming of file test-baseline.xml
Paul Dingemans committedDec 18, 2021 Configuration menu - View commit details
-
Copy full SHA for 2756678 - Browse repository at this point
Copy the full SHA 2756678View commit details -
Fix lint errors due to merge of master in branch
Paul Dingemans committedDec 18, 2021 Configuration menu - View commit details
-
Copy full SHA for 749fd76 - Browse repository at this point
Copy the full SHA 749fd76View commit details