Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert removal of unused wildcard imports (#1256) as it can lead to removal of required imports #1402

Merged
merged 3 commits into from
Mar 12, 2022
Merged

Revert removal of unused wildcard imports (#1256) as it can lead to removal of required imports #1402

merged 3 commits into from
Mar 12, 2022

Commits on Mar 12, 2022

  1. Revert removal of unused wildcard imports (pinterest#1256) as it can … 

    …lead to removal of required imports

There is no reliable way to determined whether a wildcard import is actually used
in the file. The AST does not seem to contain information about the actuall class
that an identifier refers to. It is preferred to not remove unused imports than
that needed imports are removed.

Revert pinterest#1256
Closes pinterest#1277
    @paul-dingemans
    paul-dingemans committed Mar 12, 2022
    Configuration menu
    Copy the full SHA
    de863cf View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into 1258-revert

    @paul-dingemans
    paul-dingemans committed Mar 12, 2022
    Configuration menu
    Copy the full SHA
    3b70631 View commit details
    Browse the repository at this point in the history

  3. Resolves pinterest#1393

    @paul-dingemans
    paul-dingemans committed Mar 12, 2022
    Configuration menu
    Copy the full SHA
    483b7ee View commit details
    Browse the repository at this point in the history