Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spacing between function name and the opening parenthesis #1409

Conversation

paul-dingemans
Copy link
Collaborator

Description

Enforce consistent spacing (e.g. no whitespace element at all) between function name and the opening parenthesis

Includes cleanup of AnnotationSpacingRuleTest as it broke due to existence of test which was not related to annotation spacing. Also removed the unneeded blank final line in code examples which are linted and formatted.

This rule is required for implementing the function signature rewrite rule #1341

Checklist

  • PR description added
  • tests are added
  • CHANGELOG.md is updated

In case of adding a new rule:

  • README.md is updated
  • Rule has been applied on Ktlint itself and violations are fixed

…n function name and the opening parenthesis

Includes cleanup of AnnotationSpacingRuleTest as it broke due to
existence of test which was not related to annotation spacing.
Also removed the unneeded blank final line in code examples
which are linted and formatted.

This rule is required for implementing the function signature rewrite rule pinterest#1341
@paul-dingemans paul-dingemans added this to the 0.46.0 milestone Apr 2, 2022
= added 2 commits April 26, 2022 18:22
…ning-parenthesis

# Conflicts:
#	ktlint-ruleset-experimental/src/test/kotlin/com/pinterest/ktlint/ruleset/experimental/AnnotationSpacingRuleTest.kt
@paul-dingemans paul-dingemans merged commit 835558f into pinterest:master Apr 26, 2022
@paul-dingemans paul-dingemans deleted the 1341-spacing-between-function-name-and-opening-parenthesis branch April 26, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant