Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positive FunctionTypeReferenceSpacingRule in anonymous function #1443

Conversation

paul-dingemans
Copy link
Collaborator

Description

Rule should not depend on the existence of the function identifier
as it is also possible to define anonymous functions. Checking of
anonymous and named function should be identical.

Closes #1440

  • PR description added
  • tests are added
  • CHANGELOG.md is updated

In case of adding a new rule:

  • README.md is updated
  • Rule has been applied on Ktlint itself and violations are fixed

…tion

Rule should not depend on the existence of the function identifier
as it is also possible to define anonymous functions. Checking of
anonymous and named function should be identical.

Closes pinterest#1440
@paul-dingemans paul-dingemans added this to the 0.46.0 milestone Apr 2, 2022
@paul-dingemans paul-dingemans merged commit 3472532 into pinterest:master Apr 27, 2022
@paul-dingemans paul-dingemans deleted the 1440-anonymous-function-type-reference branch April 27, 2022 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Experimental ​function-type-reference-spacing rule Unexpected whitespace for anonymous functions
1 participant