Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function-type-modifier-spacing rule #2216

Merged
merged 5 commits into from
Aug 28, 2023

Conversation

t-kameyama
Copy link
Contributor

@t-kameyama t-kameyama commented Aug 27, 2023

Description

Add function-type-modifier-spacing rule
Closes #2202

Checklist

Before submitting the PR, please check following (checks which are not relevant may be ignored):

  • Commit message are well written. In addition to a short title, the commit message also explain why a change is made.
  • At least one commit message contains a reference Closes #<xxx> or Fixes #<xxx> (replace<xxx> with issue number)
  • Tests are added
  • KtLint format has been applied on source code itself and violations are fixed
  • CHANGELOG.md is updated
  • PR description added

Documentation is updated. See difference between snapshot and release documentation

@paul-dingemans
Copy link
Collaborator

Well done! I hand not functional remarks. But, I have refactored the code so that it better aligns with style of new code in last releases. Also added two tests to verify that unexpected newline are handled.

@paul-dingemans paul-dingemans merged commit 231ad6f into pinterest:master Aug 28, 2023
21 checks passed
@t-kameyama t-kameyama deleted the issue_2202 branch August 28, 2023 22:07
@paul-dingemans paul-dingemans added this to the 1.0 (Yeah!) milestone Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Insert whitespace between suspend and opening parenthesis
2 participants