Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not insert a whitespace element as first or last child inside a composite element #2715

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

paul-dingemans
Copy link
Collaborator

Description

Prevent inserting a whitespace element as first or last element in a composite node. In such cases insert the whitespace just before or after the composite element (recursively if needed).

#2688 shows an example in which two different rules were inserting a whitespace at the same position in the code fragment but at different places in the AST. As a result two spaces were added to the formatted code instead of one.

Closes #2688

Checklist

Before submitting the PR, please check following (checks which are not relevant may be ignored):

  • Commit message are well written. In addition to a short title, the commit message also explain why a change is made.
  • At least one commit message contains a reference Closes #<xxx> or Fixes #<xxx> (replace<xxx> with issue number)
  • Tests are added
  • KtLint format has been applied on source code itself and violations are fixed
  • PR title is short and clear (it is used as description in the release changelog)
  • PR description added (background information)

Documentation is updated. See difference between snapshot and release documentation

  • Snapshot documentation in case documentation is to be released together with a code change
  • Release documentation in case documentation is related to a released version of ktlint and has to be published as soon as the change is merged to master

…mposite node

In such cases insert the whitespace just before or after the composite element (recursively if needed)

Closes #2688
…mposite node

In such cases insert the whitespace just before or after the composite element (recursively if needed)

Closes #2688
@paul-dingemans paul-dingemans added this to the 1.3.1 milestone Jun 25, 2024
@paul-dingemans paul-dingemans merged commit a4ddfaa into master Jun 25, 2024
12 checks passed
@paul-dingemans paul-dingemans deleted the 2688-curly-spacing branch June 25, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[1.3.0] Running -format adds extra spaces to class & function definition
1 participant