Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing on KDoc semicolon after other nodes. #363

Merged

Conversation

NightlyNexus
Copy link
Contributor

@NightlyNexus NightlyNexus commented Mar 30, 2019

/**
 * x;
 */

was working fine because the text was processed as "x;" but

/**
 * [x];
 */

failed because the left bracket, the identifier, and the right racket were processed as separate nodes, and then the node with the single ";" text was checked and failed.
Simply opting out of the check for all KDOC_TEXT seems fine.

Fixes #362.

/**
 * x;
 */
was working fine because the text was processed as "x;" but
/**
 * [x];
 */
failed because the left bracket, the identifier, and the right racket were processed as separate nodes, and then the node with the single ";" text was checked and failed.
Simply opting out of the check for all KDOC_TEXT seems fine.
@shashachu shashachu merged commit 1490aab into pinterest:master Apr 1, 2019
@NightlyNexus NightlyNexus deleted the eric.2019-03-30.semicolon-in-kdoc branch April 2, 2019 07:17
@erikhuizinga
Copy link

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants