Use relative schema urls internally #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maicki
reviewed
Jun 15, 2017
Sources/Core/Schema.swift
Outdated
| let lastPathComponentString = URL(string: ref)?.pathComponents.last | ||
| return URL(string:lastPathComponentString!, relativeTo:baseUrl)! | ||
| return URL(string:baseUrl.path + "/" + lastPathComponentString!)! |
There was a problem hiding this comment.
Maybe better here to use
return URL(string:baseUrl.path).URLByAppendingPathComponent(lastPathComponentString!)
// OR if baseUrl is an URL
return baseUrl.URLByAppendingPathComponent(lastPathComponentString!)Connecting file paths via/ is not safe cross platforms.
As discussed in person, given that compilers should (if they have a choice) produce bit-for-bit identical output, and a codegen tool like plank is used in builds, it makes sense for `--print_deps` to output dependencies via their relative paths. Even if all things were equal and , this is still a nice change because: 1. The print_deps output is more readable and fewer bytes since absolute paths are mostly repetitive and noisy 2. The logic for `decodeRef` can be simplified I verified that Pinterest still builds correctly with this plank and that we are still able to load schemas located in a different directory (I tested with `../../foo.json`).
bkase
force-pushed
the
use-relative-paths
branch
from
cf45196 to
f667483
Compare
Generated by 🚫 Danger |
rahul-malik
approved these changes
Jun 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in person, given that compilers should (if they have a
choice) produce bit-for-bit identical output, and a codegen tool like
plank is used in builds, it makes sense for
--print_depsto outputdependencies via their relative paths.
Even if all things were equal and we didn't care about bit-for-bit identical output, this is still a nice change because:
paths are mostly repetitive and noisy
decodeRefcan be simplifiedI verified that Pinterest still builds correctly with this plank and
that we are still able to load schemas located in a different directory
(I tested with
../../foo.json).