Objective-C init extension to better handle null model dictionary in prod builds #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nguyenhuy
commented
Sep 20, 2017
nguyenhuy
commented
- The generated initializer asserts the nullability of its model dictionary parameter. But since assertions are turned off by default for prod builds, the initializer proceeds and causes a NSInvalidErgumentException: "-[NSNull objectForKeyedSubscript:]: unrecognized selector sent to instance".
- Fix by checking nullability and bail early.
- Update Cocoa examples to include this new check.
…prod builds - The generated initializer asserts the nullability of its model dictionary parameter. But since assertions are turned off by default for prod builds, the initializer proceeds and causes a NSInvalidErgumentException: "-[NSNull objectForKeyedSubscript:]: unrecognized selector sent to instance". - Fix by checking nullability and bail early. - Update Cocoa examples to include this new check.
Generated by 🚫 Danger |
rahul-malik
approved these changes
Sep 20, 2017
nguyenhuy
added a commit
to nguyenhuy/plank
that referenced
this pull request
Sep 26, 2017
…prod builds (pinterest#80) - The generated initializer asserts the nullability of its model dictionary parameter. But since assertions are turned off by default for prod builds, the initializer proceeds and causes a NSInvalidErgumentException: "-[NSNull objectForKeyedSubscript:]: unrecognized selector sent to instance". - Fix by checking nullability and bail early. - Update Cocoa examples to include this new check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.