enhancement: make left sidebar of datadoc resizable #1346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jczhong84
reviewed
Feb 25, 2024
querybook/webapp/components/DataDocLeftSidebar/DataDocLeftSidebar.tsx
Outdated
Show resolved
Hide resolved
querybook/webapp/components/DataDocLeftSidebar/DataDocLeftSidebar.tsx
Outdated
Show resolved
Hide resolved
|
@adamstruck thanks for your PR! could you please attach some video record if possible next time, which will greatly help the code review, thanks! |
|
@jczhong84 I pushed a commit addressing your comments and added a screen recording. |
jczhong84
reviewed
Feb 27, 2024
querybook/webapp/components/DataDocLeftSidebar/DataDocLeftSidebar.scss
Outdated
Show resolved
Hide resolved
querybook/webapp/components/DataDocLeftSidebar/DataDocLeftSidebar.tsx
Outdated
Show resolved
Hide resolved
jczhong84
approved these changes
Feb 28, 2024
|
thanks for the updates |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DataDoc sidebar should always be resizable.
Prior to this the sidebar was not resizable when table info was pinned.
Screen.Recording.2024-02-26.at.10.51.03.AM.mov