Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow variables for recursion. Made templating function all server side using Jinja2 #45

Merged
merged 2 commits into from
May 11, 2020
Merged

Allow variables for recursion. Made templating function all server side using Jinja2 #45

merged 2 commits into from
May 11, 2020

Conversation

czgu
Copy link
Collaborator

@czgu czgu commented May 9, 2020 •
edited
Loading

  • Allow template nesting, done by flattening recursive definitions on the server side
  • Move templating to server side to avoid duplication, using Jinja2 instead of Mustache for future extensibility

@czgu czgu requested a review from meowcodes May 9, 2020 05:12
@czgu czgu changed the title Allow nested 2 level variables. Made templating all server side [WIP] Allow nested 2 level variables. Made templating all server side May 11, 2020
@czgu czgu marked this pull request as draft May 11, 2020 14:31
@czgu czgu changed the title [WIP] Allow nested 2 level variables. Made templating all server side Allow variables for recursion. Made templating function all server side using Jinja2 May 11, 2020
@czgu czgu marked this pull request as ready for review May 11, 2020 17:58
@meowcodes meowcodes merged commit 78e4c40 into master May 11, 2020
@czgu czgu deleted the template branch May 11, 2020 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meowcodes meowcodes meowcodes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@czgu @meowcodes