Fix deadlock when secor.upload.on.shutdown=true #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The secor.upload.on.shutdown feature worked fine if we were shutting down because we received a signal, but not if we were shutting down because a Consumer thread had crashed and the UncaughtExceptionHandler had called System.exit(1). In that case we'd get a deadlock and the program would never exit. Change the shutdown hook to do nothing if any Consumer thread called System.exit. The simplest way to implement this is to move the UncaughtExceptionHandler into the Consumer thread itself as a big try block, so I did that.
|
CI failure is maven.twttr.com being down: twitter-archive/commons#418 |
|
Thanks for fixing the twitter maven issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The secor.upload.on.shutdown feature worked fine if we were shutting down
because we received a signal, but not if we were shutting down because a
Consumer thread had crashed and the UncaughtExceptionHandler had called
System.exit(1). In that case we'd get a deadlock and the program would never
exit.
Change the shutdown hook to do nothing if any Consumer thread called
System.exit.
The simplest way to implement this is to move the UncaughtExceptionHandler into
the Consumer thread itself as a big try block, so I did that.