Add fleet level disable decider logic #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfzunigac
force-pushed
the
feature/disable_logstream_fleet_decider
branch
from
9e92d08
to
a7710f3
Compare
vahidhashemian
approved these changes
Jan 4, 2024
jfzunigac
force-pushed
the
feature/disable_logstream_fleet_decider
branch
from
dec515c
to
bdb1a45
Compare
singer/src/main/java/com/pinterest/singer/processor/DefaultLogStreamProcessor.java
Outdated
Show resolved
Hide resolved
singer/src/main/java/com/pinterest/singer/processor/DefaultLogStreamProcessor.java
Outdated
Show resolved
Hide resolved
singer/src/main/java/com/pinterest/singer/processor/DefaultLogStreamProcessor.java
Show resolved
Hide resolved
singer/src/main/java/com/pinterest/singer/utils/SingerUtils.java
Outdated
Show resolved
Hide resolved
vahidhashemian
requested changes
Jan 23, 2024
singer/src/main/java/com/pinterest/singer/processor/DefaultLogStreamProcessor.java
Outdated
Show resolved
Hide resolved
singer/src/main/java/com/pinterest/singer/processor/DefaultLogStreamProcessor.java
Outdated
Show resolved
Hide resolved
singer/src/main/java/com/pinterest/singer/processor/DefaultLogStreamProcessor.java
Outdated
Show resolved
Hide resolved
vahidhashemian
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable a logstream if fleet level disable decider is set to 100, otherwise continue with regular execution. This decider needs to be in the format:
singer_disable_<logstream_name>___<hostname_prefix>___deciderwhere all non non-alphanumeric charcters inlogstream_nameare replaced by underscores. Also introduce a utility function to retrieve hostname prefix list.