use fixed partition instead of random partition in Audit client library #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ambud
requested changes
Aug 20, 2020
...er-commons/src/main/java/com/pinterest/singer/loggingaudit/client/AuditEventKafkaSender.java
Outdated
Show resolved
Hide resolved
...er-commons/src/main/java/com/pinterest/singer/loggingaudit/client/AuditEventKafkaSender.java
Outdated
Show resolved
Hide resolved
| @@ -232,13 +255,13 @@ public void run() { | |||
| while (!cancelled.get()) { | |||
| try { | |||
| refreshPartitionIfNeeded(); | |||
| resetDefaultPartitionIfNeeded(); | |||
There was a problem hiding this comment.
Shouldn't resetDefaultPartition be called within refreshPartition? Partition Id setting can be done in one method instead of two.
Also setting valid partitionId should only be done during refresh interval checks for efficiency reasons else resetDefaultPartitionIfNeeded method will unnecessarily run the same logic again.
zzhhhzz
force-pushed
the
audit-p
branch
3 times, most recently
from
f0f885c
to
10feb1a
Compare
|
updated the PR |
|
resetCurrentPartitionIdIfNeeded() is called within refreshPartitionIfNeeded(). it will update currentPartitionId as long as it is in badPartitions set. If there is no available partitions, i.e. partitionInfoList is empty, then currentPartitionId will be set as -1. |
… currentPartitionId of the audit_event topic to send audit events. This reduces the number of TCP connections from audit client to Kafka cluster hosting the auditi_event topic. currentPartitionId is updated if it is in badPartitions set.
zzhhhzz
changed the title
ambud
approved these changes
Aug 21, 2020
kabochya
pushed a commit
to kabochya/singer
that referenced
this pull request
Feb 17, 2021
Summary: pinterest#80 pinterest#81 pinterest#82 Test Plan: on devapp mvn clean package Reviewers: vhashemian, O913 LoggingSOX, ambudsharma Reviewed By: vhashemian, O913 LoggingSOX JIRA Issue(s): LP-4635 Differential Revision: https://phabricator.pinadmin.com/D605941
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of choose random partition, AuditEventKafkaSender chooses fixed partition of the audit_event topic to send audit events. This reduces the number of TCP connections from audit client to Kafka cluster hosting the auditi_event topic.
currentPartitionId is updated if it is in badPartitions set.