toggle private build when stage type changes (#1727)

pinterest · Nov 12, 2024 · 2a4f35c · 2a4f35c
1 parent 520d3db
commit 2a4f35c
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 1 deletion.
diff --git a/...oy-service/teletraanservice/src/main/java/com/pinterest/teletraan/resource/EnvStages.java b/...oy-service/teletraanservice/src/main/java/com/pinterest/teletraan/resource/EnvStages.java
@@ -132,6 +132,8 @@ public void update(
 
         if (environBean.getStage_type() == EnvType.DEV) {
             environBean.setAllow_private_build(true);
+        } else if (origBean.getStage_type() == EnvType.DEV) {
+            environBean.setAllow_private_build(false);
         }
         environBean.setEnv_name(origBean.getEnv_name());
         environBean.setStage_name(origBean.getStage_name());

diff --git a/...service/teletraanservice/src/test/java/com/pinterest/teletraan/handler/EnvStagesTest.java b/...service/teletraanservice/src/test/java/com/pinterest/teletraan/handler/EnvStagesTest.java
@@ -44,7 +44,7 @@ public void setup() throws Exception {
     }
 
     @Test
-    public void createEnvStage() throws Exception {
+    public void updateEnvToDev_setsAllowPrivateBuildTrue() throws Exception {
         ArgumentCaptor<EnvironBean> argument = ArgumentCaptor.forClass(EnvironBean.class);
         EnvironBean envBean = new EnvironBean();
         envBean.setStage_type(EnvType.DEV);
@@ -57,4 +57,22 @@ public void createEnvStage() throws Exception {
         verify(environDAO).update(Mockito.any(), Mockito.any(), argument.capture());
         assertEquals(true, argument.getValue().getAllow_private_build());
     }
+
+    @Test
+    public void updateEnvStageOffDev_unsetsAllowPrivateBuild() throws Exception {
+        ArgumentCaptor<EnvironBean> argument = ArgumentCaptor.forClass(EnvironBean.class);
+        EnvironBean envBean = new EnvironBean();
+        EnvironBean origBean = new EnvironBean();
+        origBean.setAllow_private_build(true);
+        origBean.setStage_type(EnvType.DEV);
+        envBean.setStage_type(EnvType.STAGING);
+        Mockito.when(environDAO.getByStage(Mockito.anyString(), Mockito.anyString()))
+            .thenReturn(origBean);
+        SecurityContext mockSC = mock(SecurityContext.class);
+        Principal mockPrincipal = mock(Principal.class);
+        Mockito.when(mockSC.getUserPrincipal()).thenReturn(mockPrincipal);
+        envStages.update(mockSC, "test-env", "test-stage", envBean);
+        verify(environDAO).update(Mockito.any(), Mockito.any(), argument.capture());
+        assertEquals(false, argument.getValue().getAllow_private_build());
+    }
 }