Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deploy-agent future deps #1681

Merged
merged 3 commits into from
Jul 31, 2024

Conversation

osoriano
Copy link
Contributor

The "future" packages may have been useful for python 2/3
compatibility, but the current targets are: 3.8, 3.12

Drop the unnecessary dependencies:

  • print_function - Feature is included in 3.0
  • absolute_import - Feature is included in 3.0
  • with_metaclass - In 3.0, inheriting object makes no difference
  • PY3 - Evaluates to True in 3.0

References:

@github-actions github-actions bot added the deploy-agent Includes changes to deploy-agent label Jul 31, 2024
The "future" packages may have been useful for python 2/3
compatibility, but the current targets are: 3.8, 3.12

Drop the unnecessary dependencies:
- print_function - Feature is included in 3.0
- absolute_import - Feature is included in 3.0
- with_metaclass - In 3.0, inheriting object makes no difference
- PY3 - Evaluates to True in 3.0

References:
- https://docs.python.org/3/library/__future__.html#module-contents
@osoriano osoriano marked this pull request as ready for review July 31, 2024 15:16
@osoriano osoriano requested a review from a team as a code owner July 31, 2024 15:16
tylerwowen
tylerwowen previously approved these changes Jul 31, 2024
@osoriano osoriano merged commit 7974b4d into pinterest:master Jul 31, 2024
8 checks passed
@osoriano osoriano deleted the osoriano/rm-future-dep branch July 31, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy-agent Includes changes to deploy-agent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants