Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support write deadline for data channel #232

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Conversation

cnderrauber
Copy link
Member

@cnderrauber cnderrauber commented Dec 10, 2024

When sctp BlockWrite is enabled, datachannel
can set deadline for Write.

relates to pion/sctp#356

Description

Reference issue

Fixes #...

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 65.67%. Comparing base (6d24d74) to head (d924544).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
datachannel.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #232      +/-   ##
==========================================
- Coverage   66.06%   65.67%   -0.40%     
==========================================
  Files           4        4              
  Lines         333      335       +2     
==========================================
  Hits          220      220              
- Misses         88       90       +2     
  Partials       25       25              
Flag Coverage Δ
go 65.67% <0.00%> (-0.40%) ⬇️
wasm 65.67% <0.00%> (-0.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

When sctp BlockWrite is enabled, datachannel
can set deadline for Write.
@cnderrauber cnderrauber merged commit 687754f into master Dec 10, 2024
14 of 15 checks passed
@cnderrauber cnderrauber deleted the detach_rwtimeout branch December 10, 2024 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants