-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V2 Release! First breaking change certificate chains. #142
Conversation
Codecov Report
@@ Coverage Diff @@
## master #142 +/- ##
==========================================
- Coverage 73.49% 73.33% -0.17%
==========================================
Files 54 54
Lines 3260 3285 +25
==========================================
+ Hits 2396 2409 +13
- Misses 602 608 +6
- Partials 262 268 +6
Continue to review full report at Codecov.
|
I'm a bit puzzled by something. In a few places I now see this show up: func xxx(... rawCertificates [][]byte ...) ... {
if len(rawCertificates) == 0 {
return errLengthMismatch
}
certificate, err := x509.ParseCertificate(rawCertificates[0]) Since it seems we only ever care/check for/validate the first one, what is the idea behind accepting a |
@Sean-Der Sorry for late response but I was very busy. I created PR #152 for this branch to fix issues. And I updated Config -> Now it is similar as is crypto/tls. But for now it supports only one certificate. I have now problem to resolve issue of merge conflicts. I cannot reproduce problem on my computer... |
Update go.mod and imports for /v2
Breaking changes: * certificate, privateKey was replaced by certificate (tls.Certificate) * verifyPeerCertificates uses array of bytes for chain certificate instead of certificate(*x509.Certificate) Resolves #53
Use new option in golangci-lint `exclude-use-default` so we can lint our examples and main code at the same time.
Thank you so much @jkralik for this patch, sorry it took me so long :( but we are going to land this now and get in some other stuff!
Breaking changes:
by certificate (tls.Certificate)
certificate instead of certificate(*x509.Certificate)