Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ExportKeyingMaterial to State #240

Merged
merged 1 commit into from
Mar 30, 2020
Merged

Move ExportKeyingMaterial to State #240

merged 1 commit into from
Mar 30, 2020

Conversation

jdbruijn
Copy link
Member

Move ExportKeyingMaterial from Conn to State.

@codecov
Copy link

codecov bot commented Mar 30, 2020 •
edited
Loading

Codecov Report

Merging #240 into master will decrease coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #240      +/-   ##
==========================================
- Coverage   77.81%   77.75%   -0.07%     
==========================================
  Files          76       76              
  Lines        4039     4037       -2     
==========================================
- Hits         3143     3139       -4     
- Misses        619      620       +1     
- Partials      277      278       +1
Flag Coverage Δ
#go 77.74% <100%> (+0.01%) ⬆️
#wasm 72.84% <100%> (+0.03%) ⬆️
Impacted Files Coverage Δ
conn.go 84.17% <ø> (-0.47%) ⬇️
state.go 90.24% <100%> (+2.18%) ⬆️
internal/net/udp/conn.go 87.5% <0%> (-1.57%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1af363...4719f89. Read the comment docs.

at-wat
at-wat reviewed Mar 30, 2020
View reviewed changes
conn_test.go Outdated Show resolved Hide resolved
@jdbruijn jdbruijn force-pushed the fix/move-export-keying-material branch from 320c13e to 8e29cb5 Compare March 30, 2020 10:55
@jdbruijn
Move ExportKeyingMaterial to State
4719f89 
Move `ExportKeyingMaterial` from `Conn` to `State`.
@jdbruijn jdbruijn force-pushed the fix/move-export-keying-material branch from 8e29cb5 to 4719f89 Compare March 30, 2020 11:06
at-wat
at-wat approved these changes Mar 30, 2020
View reviewed changes
Copy link
Member

@at-wat at-wat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdbruijn jdbruijn merged commit b549159 into master Mar 30, 2020
@jdbruijn jdbruijn deleted the fix/move-export-keying-material branch March 30, 2020 13:06
@at-wat at-wat mentioned this pull request Apr 11, 2020
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@at-wat at-wat at-wat approved these changes

@daenney daenney daenney approved these changes

@igolaizola igolaizola Awaiting requested review from igolaizola

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdbruijn @daenney @at-wat