Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix connCtx.RemoteAddr() #247

Merged
merged 1 commit into from
Apr 3, 2020
Merged

Fix connCtx.RemoteAddr() #247

merged 1 commit into from
Apr 3, 2020

Conversation

at-wat
Copy link
Member

@at-wat at-wat commented Apr 3, 2020

LocalAddr of the underlying conn was returned from RemoteAddr.
Add TestLocalAddrAndRemoteAddr.

Squash #245 and #246.
Lint errors are fixed.

closes #245
closes #246

LocalAddr of the underlying conn was returned from RemoteAddr.
Add TestLocalAddrAndRemoteAddr.
@codecov
Copy link

codecov bot commented Apr 3, 2020

Codecov Report

Merging #247 into master will decrease coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #247      +/-   ##
==========================================
- Coverage   77.80%   77.75%   -0.05%     
==========================================
  Files          76       76              
  Lines        4037     4037              
==========================================
- Hits         3141     3139       -2     
- Misses        619      620       +1     
- Partials      277      278       +1     
Flag Coverage Δ
#go 77.79% <100.00%> (-0.03%) ⬇️
#wasm 72.72% <100.00%> (+0.04%) ⬆️
Impacted Files Coverage Δ
internal/net/connctx/connctx.go 86.41% <100.00%> (-2.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e14179e...7e83310. Read the comment docs.

@at-wat at-wat merged commit 513a0e3 into master Apr 3, 2020
@at-wat at-wat deleted the fix-remote-addr branch April 3, 2020 14:34
@at-wat at-wat mentioned this pull request Apr 11, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants