Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flight1parse processing exception #599

Closed
wants to merge 1 commit into from

Conversation

minlp
Copy link

@minlp minlp commented Dec 6, 2023

Description

fixing the issue where the "server hello" arrives late, if the flight1Parse method fails to handle it properly, it can lead to a failure in connecting to the media server.

Reference issue

Fixes #...
pion/webrtc#2629 (comment)

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dc751e3) 77.68% compared to head (213aa9b) 77.80%.

❗ Current head 213aa9b differs from pull request most recent head 0d9dd53. Consider uploading reports for the commit 0d9dd53 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #599      +/-   ##
==========================================
+ Coverage   77.68%   77.80%   +0.11%     
==========================================
  Files         101      101              
  Lines        6435     6437       +2     
==========================================
+ Hits         4999     5008       +9     
+ Misses       1058     1054       -4     
+ Partials      378      375       -3     
Flag Coverage Δ
go 77.82% <100.00%> (+0.11%) ⬆️
wasm 63.17% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@minlp minlp changed the title fix flight1parse processing exception, causing dtls handshake failure fix flight1parse processing exception Dec 6, 2023
@minlp minlp force-pushed the fix_dtls_flight1parse_except branch from 213aa9b to 0d9dd53 Compare December 6, 2023 09:11
@minlp minlp closed this Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant