Move NTP function to ntp package and add ToTime32 #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mengelbart
force-pushed
the
ntp-refactoring
branch
from
25625fe to
4834813
Compare
JoeTurki
approved these changes
Jan 16, 2025
mengelbart
force-pushed
the
ntp-refactoring
branch
from
4834813 to
057d141
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #301 +/- ##
==========================================
+ Coverage 71.20% 71.32% +0.11%
==========================================
Files 79 79
Lines 4529 4526 -3
==========================================
+ Hits 3225 3228 +3
+ Misses 1164 1160 -4
+ Partials 140 138 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
aalekseevx
approved these changes
Jan 16, 2025
mengelbart
force-pushed
the
ntp-refactoring
branch
from
057d141 to
5d79497
Compare
Moves all NTP related functions to the NTP package and adds a function to recover a time.Time from a uint32 encoded NTP timestamp.
mengelbart
force-pushed
the
ntp-refactoring
branch
from
5d79497 to
64e9b7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves all NTP-related functions to the NTP package and adds a function to recover a time.Time from a uint32 encoded NTP timestamp. This allows reusing code for CCFB handling (and testing).