Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix race condition in Packet.MarshalTo() #234

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Fix race condition in Packet.MarshalTo() #234

merged 1 commit into from
Jul 28, 2023

Commits on Jul 28, 2023

  1. Fix race condition in Packet.MarshalTo() 

    This was already fixed by pion#168 but got lost in pion#227. in SFUs, in order
to distribute a packet to all clients, MarshalTo() is called in
parallel by multiple routines, causing a race condition because the
padding flag is dynamically set inside MarshalTo(). This is particular
annoying when running automated tests. This PR fixes the issue by
removing this write operation as discussed in pion#168.
    @aler9
    aler9 committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    2552a6d View commit details
    Browse the repository at this point in the history