Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove av1 obu parsing #265

Closed
wants to merge 2 commits into from
Closed

remove av1 obu parsing #265

wants to merge 2 commits into from

Commits on Apr 15, 2024

  1. Remove OBU parsing from AV1Packet 

    In Pion, the (*XXXPacket).Unmarshal operation is supposed to be
fast and perform no allocation, as it is sometimes used to check
just a single flag in the packet header.  The AV1Packet
implementation breaks this property by parsing the whole list
of OBUs at Unmarshal time, even though it is likely to be unneeded.

We remove OBU parsing from Unmarshal, to make the method consistent
with the other implementations in Pion (for example, H264Packet
does not parse the list of NALs at Unmarshal time).  If OBU parsing
is required, it should be provided as a user-callable function
in codecs/av1/obu.
    @jech
    jech committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    36e9a99 View commit details
    Browse the repository at this point in the history

  2. Remove codecs/av1/frame/av1.go 

    It used to depend on the now removed OBU parsing code.
    @jech
    jech committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    0c0839d View commit details
    Browse the repository at this point in the history