Remove pending buffer when stream closed

[jerry-tao]

Description

See #239

Reference issue

See #239

[enobufs]

Removal of pending data looks good. I have one comment. Please let me know if you have any questions.

[codecov]

Codecov Report

Base: 80.87% // Head: 80.74% // Decreases project coverage by -0.13% ⚠️

Coverage data is based on head (e708220) compared to base (fc1168c).
Patch coverage: 86.11% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #245      +/-   ##
==========================================
- Coverage   80.87%   80.74%   -0.14%     
==========================================
  Files          48       48              
  Lines        4032     4046      +14     
==========================================
+ Hits         3261     3267       +6     
- Misses        629      636       +7     
- Partials      142      143       +1     

Flag	Coverage Δ
go	80.74% <86.11%> (-0.14%)	⬇️
wasm	66.53% <80.55%> (-0.93%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
chunk_payload_data.go	72.83% <ø> (ø)
association.go	84.69% <75.00%> (-0.11%)	⬇️
stream.go	91.15% <91.66%> (-1.56%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[jerry-tao]

@enobufs I think this PR is ready to merge, but there are two minor problems left:

• If close too quickly, the DECP message may be removed too.
• When the buffer is big, the sisToReset message will be delayed.

I think these could be fixed when refactoring as you said in #77.

[enobufs]

I'm glad that we came to a solution we both agree. Thanks @jerry-tao for your support.

[edaniels]

@enobufs it seems like this may have caused a regression for TestEOF in webrtc https://github.com/pion/webrtc/actions/runs/3677598072/jobs/6219774157