Consider padding when bundling chunks in packets #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #301 +/- ##
=======================================
Coverage 80.61% 80.62%
=======================================
Files 49 49
Lines 4121 4123 +2
=======================================
+ Hits 3322 3324 +2
Misses 653 653
Partials 146 146
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sukunrt
force-pushed
the
fix-chunk-bundling
branch
from
22d4ebc
to
9856bda
Compare
sukunrt
force-pushed
the
fix-chunk-bundling
branch
from
9856bda
to
d82e821
Compare
|
I'll try to look at this Monday! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently padding is not considered when decided how many chunks to bundle in to 1 packet. This causes some packets to exceed the MTU size. See the added test for a repro.