Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failed to handle DCEP: invalid Message Type #2258

Closed
dafapro opened this issue Jun 14, 2022 · 3 comments · Fixed by pion/datachannel#201
Closed

Failed to handle DCEP: invalid Message Type #2258

dafapro opened this issue Jun 14, 2022 · 3 comments · Fixed by pion/datachannel#201

Comments

@dafapro
Copy link

dafapro commented Jun 14, 2022 •
edited
Loading

Your environment.

What did you do?

create and close datachannels frequently, use those datachannels for short time communications.

What did you expect?

create data channel successfully

What happened?

datachannel ERROR: 2022/06/14 07:59:50 Failed to handle DCEP: invalid Message Type &{0 0 0 [103 97 116 101 119 97 121 45 105 79 83 45 49 54 53 53 49 57 51 53 56 57 46 54 54 54 52 51 54] []}
@dafapro
Copy link
Author

dafapro commented Jun 19, 2022

After studying the code, I guess it is about missing implementation of reusing data channel.

@shynome
Copy link

shynome commented Aug 8, 2022 •
edited
Loading 

params := &webrtc.DataChannelParameters{
	ID: &a, // set id will make it working
}

@ckousik ckousik mentioned this issue Jan 18, 2023
Closed
@KMACEL
Copy link

KMACEL commented Jul 20, 2023

Any progress on this task?

Sean-Der added a commit to pion/datachannel that referenced this issue Mar 28, 2024
@Sean-Der
Return useful error for incorrect channel type
f55406a 
Before (Wrapped for linter)
```
invalid Message Type &{%!s(datachannel.ChannelType=0)
%!s(uint16=256) %!s(uint32=0) initial_data_channel }
```

Now (Wrapped for linter)
```
expected and actual message type does not match, wanted ACK
got Open ChannelType(PartialReliableRexmitUnordered) Priority(500)
ReliabilityParameter(750) Label(Sean) Protocol(Test)
```

Resolves #125
Resolves pion/webrtc#2258
@Sean-Der Sean-Der mentioned this issue Mar 28, 2024
Merged
Sean-Der added a commit to pion/datachannel that referenced this issue Mar 28, 2024
@Sean-Der
Return useful error for incorrect channel type
c45cc49 
Before (Wrapped for linter)
```
invalid Message Type &{%!s(datachannel.ChannelType=0)
%!s(uint16=256) %!s(uint32=0) initial_data_channel }
```

Now (Wrapped for linter)
```
expected and actual message type does not match, wanted ACK
got Open ChannelType(PartialReliableRexmitUnordered) Priority(500)
ReliabilityParameter(750) Label(Sean) Protocol(Test)
```

Resolves #125
Resolves pion/webrtc#2258
Sean-Der added a commit to pion/datachannel that referenced this issue Mar 28, 2024
@Sean-Der
Return useful error for incorrect channel type
9449b50 
Before (Wrapped for linter)
```
invalid Message Type &{%!s(datachannel.ChannelType=0)
%!s(uint16=256) %!s(uint32=0) initial_data_channel }
```

Now (Wrapped for linter)
```
expected and actual message type does not match, wanted ACK
got Open ChannelType(PartialReliableRexmitUnordered) Priority(500)
ReliabilityParameter(750) Label(Sean) Protocol(Test)
```

Resolves #125
Resolves pion/webrtc#2258
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Return useful error for incorrect channel type pion/datachannel
3 participants
@shynome @KMACEL @dafapro