Fix check for unchanged transceivers in CreateOffer #1658
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1658 +/- ##
==========================================
- Coverage 75.18% 75.11% -0.08%
==========================================
Files 79 79
Lines 5694 5694
==========================================
- Hits 4281 4277 -4
- Misses 1035 1037 +2
- Partials 378 380 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
We used to reverse-engineer the list of transceivers from the generated offer, which is fragile. Check that the list of transceivers hasn't been changed instead.
jech
force-pushed
the
fix-transceivers-check
branch
from
6805a26
to
c47c1e1
Compare
There was a problem hiding this comment.
I think we can almost take this, but need to check some stuff.
Right now when generating the offer and we are missing codecs we will generate a non-bundle SDP (which will confuse the remote peer). So I need to investigate this further, but we should leave as a note to make sure this gets done :)
|
I am going to open another PR that gives a better error message for #1702 |
This makes the check in CreateOffer more conservative but also less
fragile. It works around #1656, but I'm not sure it's the underlying
cause (the SDP quoted in that issue looks broken to my untrained eyes).