Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix updateHeaderExtension for cloned MediaEngine #1682

Merged
merged 1 commit into from
Feb 17, 2021

Conversation

mission-liao
Copy link
Contributor

Description

It addresses the issue that unable to updateHeaderExtension for cloned
MediaEngine, which is resulted from previous commit:

c8b7aa3

Reference issue

Fixes a possible(?) side-effect from the PR for #1662

It addresses the issue that unable to updateHeaderExtension for cloned
MediaEngine, which is resulted from previous commit:

c8b7aa3
@codecov
Copy link

codecov bot commented Feb 17, 2021

Codecov Report

Merging #1682 (7c1f7aa) into master (19537f2) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1682      +/-   ##
==========================================
- Coverage   75.02%   75.00%   -0.03%     
==========================================
  Files          79       79              
  Lines        5718     5720       +2     
==========================================
  Hits         4290     4290              
- Misses       1055     1056       +1     
- Partials      373      374       +1     
Flag Coverage Δ
go 76.57% <100.00%> (-0.03%) ⬇️
wasm 69.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mediaengine.go 80.99% <100.00%> (+0.15%) ⬆️
dtlstransport.go 67.00% <0.00%> (-2.00%) ⬇️
peerconnection.go 73.84% <0.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19537f2...7c1f7aa. Read the comment docs.

Copy link
Member

@Sean-Der Sean-Der left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! I think it’s ok to always initialize, not that much overhead vs complexity.

Tag a new version if you want, thanks so much :)

@mission-liao
Copy link
Contributor Author

OK, would provide another commit to make it always initialize later. It would be less complicated.

@mission-liao
Copy link
Contributor Author

I've looked around codes for negotiatedHeaderExtensions, and think it's still better to keep the last commit.

The behavior: updateHeaderExtension would do nothing if RegisterHeaderExtension is not called seems reasonable.

Being of two minds.

@mission-liao mission-liao merged commit 8474033 into master Feb 17, 2021
@mission-liao mission-liao deleted the fix-cloned-mediaengine branch February 17, 2021 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants