Revert "Make RTPTransceiver Stopped an atomic" #1969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1969 +/- ##
==========================================
- Coverage 76.87% 76.86% -0.01%
==========================================
Files 85 85
Lines 6213 6206 -7
==========================================
- Hits 4776 4770 -6
- Misses 1030 1032 +2
+ Partials 407 404 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sean-Der
approved these changes
Sep 24, 2021
This reverts commit 6c36200. This commit would cause sender.ReadRTCP() to never return even when pc associated with this sender was closed. The aftermath is leaked goroutines that will never stop.
digitalix
force-pushed
the
digitalix/revert-rtp-transceiver-atomic
branch
from
a454532
to
0f4f850
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 6c36200.