WIP: Adding black box testing #2356
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using an improvment of pion/datachannel, the channel opener can now set an event to be called when the DATA_CHANNEL_ACK message is recieved Resolves pion#1063 Relates to pion/datachannel#81
Codecov ReportBase: 77.55% // Head: 77.58% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2356 +/- ##
==========================================
+ Coverage 77.55% 77.58% +0.03%
==========================================
Files 87 87
Lines 9272 9272
==========================================
+ Hits 7191 7194 +3
+ Misses 1648 1646 -2
+ Partials 433 432 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There's a testing task I've been using in my projects and I'm happy to contribute. For now, there's only one test - the data channel example - and it passes over the Firefox and Chromium browsers (webkit is WIP).
I've made as little changes as possible to the example: adding
data-test-idin a couple of places and making main.go respond promptly on establishing a connection. It could be premature optimization, but waiting 5 seconds every time seems silly.The biggest open issue is the example's main.go. It imports pion from GitHub.com instead of using the source, testing the wrong source. I'm not sure what's the best way to hack this and I'd appreciate your idea and even better, a PR.