Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate h.264 codec parameters from defaults #2465

Merged
merged 1 commit into from
Aug 5, 2023

Conversation

esonderegger
Copy link
Contributor

It appears as though these two sets of lines are identical:

This PR removes the second set. Question: does order matter here? If so, in which order should the h.264 codec parameters be registered with the media engine?

@codecov
Copy link

codecov bot commented Aug 5, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.16% ⚠️

Comparison is base (ebd6753) 77.78% compared to head (96a9888) 77.63%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2465      +/-   ##
==========================================
- Coverage   77.78%   77.63%   -0.16%     
==========================================
  Files          87       87              
  Lines        9374     9378       +4     
==========================================
- Hits         7292     7281      -11     
- Misses       1653     1666      +13     
- Partials      429      431       +2     
Flag Coverage Δ
go 79.40% <100.00%> (-0.17%) ⬇️
wasm 70.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
mediaengine.go 92.02% <100.00%> (+0.06%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

VP9 has been moved below AV1. Some missing H264 profiles have been added
@Sean-Der Sean-Der merged commit f0a5355 into pion:master Aug 5, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants