Add RTPTransceiver func #2527
Merged
Add RTPTransceiver func #2527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! Can you update the doc to match the other functions. Something like Line 105 in e9738af |
Returns the RTPTransceiver currently associated with this RTPReceiver
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #2527 +/- ##
==========================================
- Coverage 77.71% 77.68% -0.04%
==========================================
Files 87 87
Lines 9360 9365 +5
==========================================
+ Hits 7274 7275 +1
- Misses 1655 1659 +4
Partials 431 431
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
Thank you @do-hyung-kim! After the tests pass I will merge and tag a new version :) |
|
Hi @Sean-Der Thank you for your feedback and help. :) |
Sean-Der
approved these changes
Aug 2, 2023
|
@do-hyung-kim tagged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there! I want to use RTPTransceiver in on track func. RTP TRANSCEIVER is provided in the ON TRACK WEB API, but when I looked at it, it was difficult to access the RTP TRANSCEIVER in PION's ON_TRACK. I'm raising the PR because I would like to add a function to get the TR from the receiver rather than changing the supplied arguments of the ON_TRACK FUNC.
Description: